[PATCH] ftrace: use .sched.text, not .text.sched in recordmcount.pl.

[PATCH] ftrace: use .sched.text, not .text.sched in recordmcount.pl.

[Tim Abbott]

The only references in the kernel to the .text.sched section are in
recordmcount.pl.  Since the code it has is intended to be example code
it should refer to real kernel sections.  So change it to .sched.text
instead.

Signed-off-by: Tim Abbott <tabbott@mit.edu>
Cc: Steven Rostedt <srostedt@redhat.com>
---
 scripts/recordmcount.pl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index 409596e..0fae7da 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -26,7 +26,7 @@
 # which will also be the location of that section after final link.
 # e.g.
 #
-#  .section ".text.sched"
+#  .section ".sched.text", "ax"
 #  .globl my_func
 #  my_func:
 #        [...]
@@ -39,7 +39,7 @@
 #        [...]
 #
 # Both relocation offsets for the mcounts in the above example will be
-# offset from .text.sched. If we make another file called tmp.s with:
+# offset from .sched.text. If we make another file called tmp.s with:
 #
 #  .section __mcount_loc
 #  .quad  my_func + 0x5
@@ -51,7 +51,7 @@
 # But this gets hard if my_func is not globl (a static function).
 # In such a case we have:
 #
-#  .section ".text.sched"
+#  .section ".sched.text", "ax"
 #  my_func:
 #        [...]
 #        call mcount  (offset: 0x5)
-- 
1.6.2.1

Re: [PATCH] ftrace: use .sched.text, not .text.sched in recordmcount.pl.

[Sam Ravnborg]

On Thu, Apr 30, 2009 at 08:06:11PM -0400, Tim Abbott wrote:
> The only references in the kernel to the .text.sched section are in
> recordmcount.pl.  Since the code it has is intended to be example code
> it should refer to real kernel sections.  So change it to .sched.text
> instead.
> 
> Signed-off-by: Tim Abbott <tabbott@mit.edu>
> Cc: Steven Rostedt <srostedt@redhat.com>

Steven - this change is independent of the ongoing
section rework and is a pure documentation fix.

Please apply it with my ack.

	Sam

[Kept whole patch for reference]

> ---
>  scripts/recordmcount.pl |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index 409596e..0fae7da 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -26,7 +26,7 @@
>  # which will also be the location of that section after final link.
>  # e.g.
>  #
> -#  .section ".text.sched"
> +#  .section ".sched.text", "ax"
>  #  .globl my_func
>  #  my_func:
>  #        [...]
> @@ -39,7 +39,7 @@
>  #        [...]
>  #
>  # Both relocation offsets for the mcounts in the above example will be
> -# offset from .text.sched. If we make another file called tmp.s with:
> +# offset from .sched.text. If we make another file called tmp.s with:
>  #
>  #  .section __mcount_loc
>  #  .quad  my_func + 0x5
> @@ -51,7 +51,7 @@
>  # But this gets hard if my_func is not globl (a static function).
>  # In such a case we have:
>  #
> -#  .section ".text.sched"
> +#  .section ".sched.text", "ax"
>  #  my_func:
>  #        [...]
>  #        call mcount  (offset: 0x5)
> -- 
> 1.6.2.1
> 

Re: [PATCH] ftrace: use .sched.text, not .text.sched in recordmcount.pl.

[Steven Rostedt]

On Mon, 2009-05-04 at 21:30 +0200, Sam Ravnborg wrote:
> On Thu, Apr 30, 2009 at 08:06:11PM -0400, Tim Abbott wrote:
> > The only references in the kernel to the .text.sched section are in
> > recordmcount.pl.  Since the code it has is intended to be example code
> > it should refer to real kernel sections.  So change it to .sched.text
> > instead.
> > 
> > Signed-off-by: Tim Abbott <tabbott@mit.edu>
> > Cc: Steven Rostedt <srostedt@redhat.com>
> 
> Steven - this change is independent of the ongoing
> section rework and is a pure documentation fix.
> 
> Please apply it with my ack.
> 
> 	Sam

Will do, Thanks!

-- Steve

> 
> [Kept whole patch for reference]
> 
> > ---
> >  scripts/recordmcount.pl |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> > index 409596e..0fae7da 100755
> > --- a/scripts/recordmcount.pl
> > +++ b/scripts/recordmcount.pl
> > @@ -26,7 +26,7 @@
> >  # which will also be the location of that section after final link.
> >  # e.g.
> >  #
> > -#  .section ".text.sched"
> > +#  .section ".sched.text", "ax"
> >  #  .globl my_func
> >  #  my_func:
> >  #        [...]
> > @@ -39,7 +39,7 @@
> >  #        [...]
> >  #
> >  # Both relocation offsets for the mcounts in the above example will be
> > -# offset from .text.sched. If we make another file called tmp.s with:
> > +# offset from .sched.text. If we make another file called tmp.s with:
> >  #
> >  #  .section __mcount_loc
> >  #  .quad  my_func + 0x5
> > @@ -51,7 +51,7 @@
> >  # But this gets hard if my_func is not globl (a static function).
> >  # In such a case we have:
> >  #
> > -#  .section ".text.sched"
> > +#  .section ".sched.text", "ax"
> >  #  my_func:
> >  #        [...]
> >  #        call mcount  (offset: 0x5)
> > -- 
> > 1.6.2.1
> > 

[tip:tracing/core] ftrace: use .sched.text, not .text.sched in recordmcount.pl

[tip-bot for Tim Abbott]

Commit-ID:  31b6e76e21b2ffd3cb2f6fe4149790a9fdadce2d
Gitweb:     http://git.kernel.org/tip/31b6e76e21b2ffd3cb2f6fe4149790a9fdadce2d
Author:     Tim Abbott <tabbott@MIT.EDU>
AuthorDate: Thu, 30 Apr 2009 20:06:11 -0400
Committer:  Steven Rostedt <rostedt@goodmis.org>
CommitDate: Tue, 5 May 2009 19:17:22 -0400

ftrace: use .sched.text, not .text.sched in recordmcount.pl

The only references in the kernel to the .text.sched section are in
recordmcount.pl.  Since the code it has is intended to be example code
it should refer to real kernel sections.  So change it to .sched.text
instead.

[ Impact: consistency in comments ]

Signed-off-by: Tim Abbott <tabbott@mit.edu>
LKML-Reference: <1241136371-10768-1-git-send-email-tabbott@mit.edu>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>


---
 scripts/recordmcount.pl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index 409596e..0fae7da 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -26,7 +26,7 @@
 # which will also be the location of that section after final link.
 # e.g.
 #
-#  .section ".text.sched"
+#  .section ".sched.text", "ax"
 #  .globl my_func
 #  my_func:
 #        [...]
@@ -39,7 +39,7 @@
 #        [...]
 #
 # Both relocation offsets for the mcounts in the above example will be
-# offset from .text.sched. If we make another file called tmp.s with:
+# offset from .sched.text. If we make another file called tmp.s with:
 #
 #  .section __mcount_loc
 #  .quad  my_func + 0x5
@@ -51,7 +51,7 @@
 # But this gets hard if my_func is not globl (a static function).
 # In such a case we have:
 #
-#  .section ".text.sched"
+#  .section ".sched.text", "ax"
 #  my_func:
 #        [...]
 #        call mcount  (offset: 0x5)