public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Andy Lutomirski <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: peterz@infradead.org, jpoimboe@redhat.com, brgerst@gmail.com,
	hpa@zytor.com, stsp@list.ru, torvalds@linux-foundation.org,
	dvlasenk@redhat.com, tglx@linutronix.de, mingo@kernel.org,
	luto@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de
Subject: [tip:x86/pti] selftests/x86/entry_from_vm86: Exit with 1 if we fail
Date: Wed, 14 Mar 2018 01:46:16 -0700	[thread overview]
Message-ID: <tip-327d53d005ca47b10eae940616ed11c569f75a9b@git.kernel.org> (raw)
In-Reply-To: <b1cc37144038958a469c8f70a5f47a6a5638636a.1521003603.git.luto@kernel.org>

Commit-ID:  327d53d005ca47b10eae940616ed11c569f75a9b
Gitweb:     https://git.kernel.org/tip/327d53d005ca47b10eae940616ed11c569f75a9b
Author:     Andy Lutomirski <luto@kernel.org>
AuthorDate: Tue, 13 Mar 2018 22:03:10 -0700
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 14 Mar 2018 09:21:01 +0100

selftests/x86/entry_from_vm86: Exit with 1 if we fail

Fix a logic error that caused the test to exit with 0 even if test
cases failed.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stas Sergeev <stsp@list.ru>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bartoldeman@gmail.com
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/b1cc37144038958a469c8f70a5f47a6a5638636a.1521003603.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/testing/selftests/x86/entry_from_vm86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/entry_from_vm86.c b/tools/testing/selftests/x86/entry_from_vm86.c
index 361466a2eaef..6e85f0d0498d 100644
--- a/tools/testing/selftests/x86/entry_from_vm86.c
+++ b/tools/testing/selftests/x86/entry_from_vm86.c
@@ -318,7 +318,7 @@ int main(void)
 	clearhandler(SIGSEGV);
 
 	/* Make sure nothing explodes if we fork. */
-	if (fork() > 0)
+	if (fork() == 0)
 		return 0;
 
 	return (nerrs == 0 ? 0 : 1);

  reply	other threads:[~2018-03-14  8:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14  5:03 [PATCH 0/3] x86/vm86/32: A bugfix and a matching test improvement Andy Lutomirski
2018-03-14  5:03 ` [PATCH 1/3] selftests/x86/entry_from_vm86: Exit with 1 if we fail Andy Lutomirski
2018-03-14  8:46   ` tip-bot for Andy Lutomirski [this message]
2018-03-14  5:03 ` [PATCH 2/3] selftests/x86/entry_from_vm86: Add test cases for POPF Andy Lutomirski
2018-03-14  8:46   ` [tip:x86/pti] " tip-bot for Andy Lutomirski
2018-03-14  5:03 ` [PATCH 3/3] x86/vm86/32: Fix POPF emulation Andy Lutomirski
2018-03-14  8:47   ` [tip:x86/pti] " tip-bot for Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-327d53d005ca47b10eae940616ed11c569f75a9b@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=stsp@list.ru \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox