From: tip-bot for Steven Rostedt <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
acme@redhat.com, rostedt@goodmis.org, namhyung@kernel.org,
tglx@linutronix.de
Subject: [tip:perf/core] tools lib traceevent: Fix output of %llu for 64 bit values read on 32 bit machines
Date: Thu, 26 Nov 2015 00:21:07 -0800 [thread overview]
Message-ID: <tip-32abc2ede536aae52978d6c0a8944eb1df14f460@git.kernel.org> (raw)
In-Reply-To: <20151116172516.4b79b109@gandalf.local.home>
Commit-ID: 32abc2ede536aae52978d6c0a8944eb1df14f460
Gitweb: http://git.kernel.org/tip/32abc2ede536aae52978d6c0a8944eb1df14f460
Author: Steven Rostedt <rostedt@goodmis.org>
AuthorDate: Mon, 16 Nov 2015 17:25:16 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 23 Nov 2015 19:17:23 -0300
tools lib traceevent: Fix output of %llu for 64 bit values read on 32 bit machines
When a long value is read on 32 bit machines for 64 bit output, the
parsing needs to change "%lu" into "%llu", as the value is read
natively.
Unfortunately, if "%llu" is already there, the code will add another "l"
to it and fail to parse it properly.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20151116172516.4b79b109@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/traceevent/event-parse.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 2a912df..68276f3 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4968,13 +4968,12 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
sizeof(long) != 8) {
char *p;
- ls = 2;
/* make %l into %ll */
- p = strchr(format, 'l');
- if (p)
+ if (ls == 1 && (p = strchr(format, 'l')))
memmove(p+1, p, strlen(p)+1);
else if (strcmp(format, "%p") == 0)
strcpy(format, "0x%llx");
+ ls = 2;
}
switch (ls) {
case -2:
next prev parent reply other threads:[~2015-11-26 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 20:33 [PATCH] tools lib traceevents: Fix output of %llu for 64 bit values read on 32 bit machines Steven Rostedt
2015-11-16 22:23 ` Steven Rostedt
2015-11-16 22:25 ` [PATCH v2] " Steven Rostedt
2015-11-17 0:20 ` Namhyung Kim
2015-11-17 2:43 ` Steven Rostedt
2015-11-23 22:18 ` Arnaldo Carvalho de Melo
2015-11-26 8:21 ` tip-bot for Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-09 20:40 [PATCH 4/4] tools lib traceevent: " Steven Rostedt
2016-03-05 8:19 ` [tip:perf/core] " tip-bot for Steven Rostedt (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-32abc2ede536aae52978d6c0a8944eb1df14f460@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).