From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paulus@samba.org, hpa@zytor.com,
mingo@redhat.com, a.p.zijlstra@chello.nl, tglx@linutronix.de,
cjashfor@linux.vnet.ibm.com, mingo@elte.hu
Subject: [tip:perfcounters/core] perf_counter: PERF_RECORD_TIME
Date: Tue, 7 Apr 2009 09:08:13 GMT [thread overview]
Message-ID: <tip-339f7c90b8a2f3aa2dd4267e79f797999e8a3c59@git.kernel.org> (raw)
In-Reply-To: <20090406094518.024173282@chello.nl>
Commit-ID: 339f7c90b8a2f3aa2dd4267e79f797999e8a3c59
Gitweb: http://git.kernel.org/tip/339f7c90b8a2f3aa2dd4267e79f797999e8a3c59
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
AuthorDate: Mon, 6 Apr 2009 11:45:06 +0200
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 7 Apr 2009 10:48:57 +0200
perf_counter: PERF_RECORD_TIME
By popular request, provide means to log a timestamp along with the
counter overflow event.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
LKML-Reference: <20090406094518.024173282@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/perf_counter.h | 2 ++
kernel/perf_counter.c | 14 ++++++++++++++
2 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index ca2d4df..928a7fa 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -102,6 +102,7 @@ enum perf_counter_record_format {
PERF_RECORD_TID = 1U << 1,
PERF_RECORD_GROUP = 1U << 2,
PERF_RECORD_CALLCHAIN = 1U << 3,
+ PERF_RECORD_TIME = 1U << 4,
};
/*
@@ -221,6 +222,7 @@ enum perf_event_type {
__PERF_EVENT_TID = PERF_RECORD_TID,
__PERF_EVENT_GROUP = PERF_RECORD_GROUP,
__PERF_EVENT_CALLCHAIN = PERF_RECORD_CALLCHAIN,
+ __PERF_EVENT_TIME = PERF_RECORD_TIME,
};
#ifdef __KERNEL__
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index c841563..19990d1 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -1826,6 +1826,7 @@ static void perf_counter_output(struct perf_counter *counter,
} group_entry;
struct perf_callchain_entry *callchain = NULL;
int callchain_size = 0;
+ u64 time;
header.type = PERF_EVENT_COUNTER_OVERFLOW;
header.size = sizeof(header);
@@ -1862,6 +1863,16 @@ static void perf_counter_output(struct perf_counter *counter,
}
}
+ if (record_type & PERF_RECORD_TIME) {
+ /*
+ * Maybe do better on x86 and provide cpu_clock_nmi()
+ */
+ time = sched_clock();
+
+ header.type |= __PERF_EVENT_TIME;
+ header.size += sizeof(u64);
+ }
+
ret = perf_output_begin(&handle, counter, header.size, nmi);
if (ret)
return;
@@ -1895,6 +1906,9 @@ static void perf_counter_output(struct perf_counter *counter,
if (callchain)
perf_output_copy(&handle, callchain, callchain_size);
+ if (record_type & PERF_RECORD_TIME)
+ perf_output_put(&handle, time);
+
perf_output_end(&handle);
}
next prev parent reply other threads:[~2009-04-07 9:10 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 9:44 [PATCH 00/15] various perf counter bits Peter Zijlstra
2009-04-06 9:44 ` [PATCH 01/15] perf_counter: update mmap() counter read, take 2 Peter Zijlstra
2009-04-07 9:06 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 02/15] perf_counter: add more context information Peter Zijlstra
2009-04-07 9:07 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 03/15] perf_counter: SIGIO support Peter Zijlstra
2009-04-07 9:07 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 04/15] perf_counter: generalize pending infrastructure Peter Zijlstra
2009-04-07 9:07 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 05/15] perf_counter: x86: self-IPI for pending work Peter Zijlstra
2009-04-07 9:07 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 06/15] perf_counter: theres more to overflow than writing events Peter Zijlstra
2009-04-07 9:07 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 07/15] perf_counter: fix the mlock accounting Peter Zijlstra
2009-04-07 9:08 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 08/15] perf_counter: PERF_RECORD_TIME Peter Zijlstra
2009-04-07 9:08 ` Peter Zijlstra [this message]
2009-04-06 9:45 ` [PATCH 09/15] perf_counter: counter overflow limit Peter Zijlstra
2009-04-07 9:08 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 10/15] perf_counter: comment the perf_event_type stuff Peter Zijlstra
2009-04-07 9:08 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 11/15] perf_counter: change event defenition Peter Zijlstra
2009-04-07 9:08 ` [tip:perfcounters/core] perf_counter: change event definition Peter Zijlstra
2009-04-06 9:45 ` [PATCH 12/15] perf_counter: rework context time Peter Zijlstra
2009-04-07 9:09 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 13/15] perf_counter: rework the task clock software counter Peter Zijlstra
2009-04-07 9:09 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-07 9:36 ` [tip:perfcounters/core] x86, perfcounters: add atomic64_xchg() Ingo Molnar
2009-04-07 11:19 ` Paul Mackerras
2009-04-07 13:28 ` Ingo Molnar
2009-04-07 10:06 ` Ingo Molnar
2009-04-06 9:45 ` [PATCH 14/15] perf_counter: remove rq->lock usage Peter Zijlstra
2009-04-07 9:09 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-06 9:45 ` [PATCH 15/15] perf_counter: minimize context time updates Peter Zijlstra
2009-04-07 9:09 ` [tip:perfcounters/core] " Peter Zijlstra
2009-04-07 9:21 ` [PATCH 00/15] various perf counter bits Ingo Molnar
2009-04-07 9:21 ` Ingo Molnar
2009-04-07 9:33 ` Ingo Molnar
2009-04-07 9:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-339f7c90b8a2f3aa2dd4267e79f797999e8a3c59@git.kernel.org \
--to=a.p.zijlstra@chello.nl \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox