From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbcHPSO7 (ORCPT ); Tue, 16 Aug 2016 14:14:59 -0400 Received: from terminus.zytor.com ([198.137.202.10]:38458 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbcHPSO5 (ORCPT ); Tue, 16 Aug 2016 14:14:57 -0400 Date: Tue, 16 Aug 2016 11:13:42 -0700 From: tip-bot for Jiri Olsa Message-ID: Cc: dsahern@gmail.com, namhyung@kernel.org, a.p.zijlstra@chello.nl, tglx@linutronix.de, mingo@kernel.org, jolsa@kernel.org, jolsa@redhat.com, acme@redhat.com, linux-kernel@vger.kernel.org, mpetlan@redhat.com, hpa@zytor.com Reply-To: jolsa@redhat.com, linux-kernel@vger.kernel.org, mpetlan@redhat.com, acme@redhat.com, hpa@zytor.com, dsahern@gmail.com, namhyung@kernel.org, tglx@linutronix.de, a.p.zijlstra@chello.nl, jolsa@kernel.org, mingo@kernel.org In-Reply-To: <1470905457-18311-1-git-send-email-jolsa@kernel.org> References: <1470905457-18311-1-git-send-email-jolsa@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf tools mem: Fix -t store option for record command Git-Commit-ID: 33da54fa86e29b87fe1e83bd0f15b4ef2be53ecb X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 33da54fa86e29b87fe1e83bd0f15b4ef2be53ecb Gitweb: http://git.kernel.org/tip/33da54fa86e29b87fe1e83bd0f15b4ef2be53ecb Author: Jiri Olsa AuthorDate: Thu, 11 Aug 2016 10:50:57 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 12 Aug 2016 14:39:48 -0300 perf tools mem: Fix -t store option for record command Michael reported 'perf mem -t store record' being broken. The reason is latest rework of this area: commit acbe613e0c03 ("perf tools: Add monitored events array") We don't mark perf_mem_events store record when -t store option is specified. Committer notes: Before: # perf mem -t store record usleep 1 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.020 MB perf.data (7 samples) ] # perf evlist cycles:ppp # After: # perf mem -t store record usleep 1 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.020 MB perf.data (7 samples) ] # perf evlist cpu/mem-stores/P # Reported-by: Michael Petlan Signed-off-by: Jiri Olsa Tested-by: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Fixes: acbe613e0c03 ("perf tools: Add monitored events array") Link: http://lkml.kernel.org/r/1470905457-18311-1-git-send-email-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-mem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c index d608a2c..d1ce29b 100644 --- a/tools/perf/builtin-mem.c +++ b/tools/perf/builtin-mem.c @@ -88,6 +88,9 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem) if (mem->operation & MEM_OPERATION_LOAD) perf_mem_events[PERF_MEM_EVENTS__LOAD].record = true; + if (mem->operation & MEM_OPERATION_STORE) + perf_mem_events[PERF_MEM_EVENTS__STORE].record = true; + if (perf_mem_events[PERF_MEM_EVENTS__LOAD].record) rec_argv[i++] = "-W";