From: tip-bot for Wang Nan <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, lizefan@huawei.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com,
wangnan0@huawei.com
Subject: [tip:perf/urgent] perf symbols: Check kptr_restrict for root
Date: Sun, 29 May 2016 11:19:15 -0700 [thread overview]
Message-ID: <tip-38272dc4f1b17437871b786d567e1242d0904f5a@git.kernel.org> (raw)
In-Reply-To: <1464081688-167940-1-git-send-email-wangnan0@huawei.com>
Commit-ID: 38272dc4f1b17437871b786d567e1242d0904f5a
Gitweb: http://git.kernel.org/tip/38272dc4f1b17437871b786d567e1242d0904f5a
Author: Wang Nan <wangnan0@huawei.com>
AuthorDate: Tue, 24 May 2016 09:21:27 +0000
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 27 May 2016 09:41:23 -0300
perf symbols: Check kptr_restrict for root
If kptr_restrict is set to 2, even root is not allowed to see pointers.
This patch checks kptr_restrict even if euid == 0. For root, report
error if kptr_restrict is 2.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1464081688-167940-1-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/symbol.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 20f9cb3..54c4ff2 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1933,17 +1933,17 @@ int setup_intlist(struct intlist **list, const char *list_str,
static bool symbol__read_kptr_restrict(void)
{
bool value = false;
+ FILE *fp = fopen("/proc/sys/kernel/kptr_restrict", "r");
- if (geteuid() != 0) {
- FILE *fp = fopen("/proc/sys/kernel/kptr_restrict", "r");
- if (fp != NULL) {
- char line[8];
+ if (fp != NULL) {
+ char line[8];
- if (fgets(line, sizeof(line), fp) != NULL)
- value = atoi(line) != 0;
+ if (fgets(line, sizeof(line), fp) != NULL)
+ value = (geteuid() != 0) ?
+ (atoi(line) != 0) :
+ (atoi(line) == 2);
- fclose(fp);
- }
+ fclose(fp);
}
return value;
prev parent reply other threads:[~2016-05-29 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 9:21 [PATCH 1/2] perf tools: Check kptr_restrict for root Wang Nan
2016-05-24 9:21 ` [PATCH 2/2] perf record: Fix crash when kptr is restricted Wang Nan
2016-05-24 12:26 ` Arnaldo Carvalho de Melo
2016-05-24 12:41 ` Arnaldo Carvalho de Melo
2016-05-29 18:19 ` [tip:perf/urgent] " tip-bot for Wang Nan
2016-05-24 12:25 ` [PATCH 1/2] perf tools: Check kptr_restrict for root Arnaldo Carvalho de Melo
2016-05-29 18:19 ` tip-bot for Wang Nan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-38272dc4f1b17437871b786d567e1242d0904f5a@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox