From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751062AbeAPDmD (ORCPT + 1 other); Mon, 15 Jan 2018 22:42:03 -0500 Received: from terminus.zytor.com ([65.50.211.136]:46407 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750908AbeAPDmB (ORCPT ); Mon, 15 Jan 2018 22:42:01 -0500 Date: Mon, 15 Jan 2018 19:37:50 -0800 From: tip-bot for Josh Poimboeuf Message-ID: Cc: peterz@infradead.org, hpa@zytor.com, jpoimboe@redhat.com, torvalds@linux-foundation.org, mingo@kernel.org, M4rkusXXL@web.de, linux-kernel@vger.kernel.org, tglx@linutronix.de Reply-To: M4rkusXXL@web.de, linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, hpa@zytor.com, jpoimboe@redhat.com, torvalds@linux-foundation.org, mingo@kernel.org In-Reply-To: <406a3d00a21225eee2819844048e17f68523ccf6.1516025651.git.jpoimboe@redhat.com> References: <406a3d00a21225eee2819844048e17f68523ccf6.1516025651.git.jpoimboe@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/pti] objtool: Improve error message for bad file argument Git-Commit-ID: 385d11b152c4eb638eeb769edcb3249533bb9a00 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Commit-ID: 385d11b152c4eb638eeb769edcb3249533bb9a00 Gitweb: https://git.kernel.org/tip/385d11b152c4eb638eeb769edcb3249533bb9a00 Author: Josh Poimboeuf AuthorDate: Mon, 15 Jan 2018 08:17:08 -0600 Committer: Ingo Molnar CommitDate: Tue, 16 Jan 2018 01:27:27 +0100 objtool: Improve error message for bad file argument If a nonexistent file is supplied to objtool, it complains with a non-helpful error: open: No such file or directory Improve it to: objtool: Can't open 'foo': No such file or directory Reported-by: Markus Signed-off-by: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/406a3d00a21225eee2819844048e17f68523ccf6.1516025651.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- tools/objtool/elf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 2446015..c1c3386 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -26,6 +26,7 @@ #include #include #include +#include #include "elf.h" #include "warn.h" @@ -358,7 +359,8 @@ struct elf *elf_open(const char *name, int flags) elf->fd = open(name, flags); if (elf->fd == -1) { - perror("open"); + fprintf(stderr, "objtool: Can't open '%s': %s\n", + name, strerror(errno)); goto err; }