From: tip-bot for Steven Rostedt <rostedt@goodmis.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
rostedt@goodmis.org, tglx@linutronix.de
Subject: [tip:irq/urgent] genirq: fix comment to say IRQ_WAKE_THREAD
Date: Tue, 12 May 2009 20:12:29 GMT [thread overview]
Message-ID: <tip-39a2eddb9b62959dc55c6978b5eaeb3dd57c5ff2@git.kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0905121431020.13338@gandalf.stny.rr.com>
Commit-ID: 39a2eddb9b62959dc55c6978b5eaeb3dd57c5ff2
Gitweb: http://git.kernel.org/tip/39a2eddb9b62959dc55c6978b5eaeb3dd57c5ff2
Author: Steven Rostedt <rostedt@goodmis.org>
AuthorDate: Tue, 12 May 2009 14:35:54 -0400
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 12 May 2009 22:11:29 +0200
genirq: fix comment to say IRQ_WAKE_THREAD
Trying to implement a driver to use threaded irqs, I was confused when the
return value to use that was described in the comment above
request_threaded_irq was not defined.
Turns out that the enum is IRQ_WAKE_THREAD where as the comment said
IRQ_THREAD_WAKE.
[Impact: do not confuse developers with wrong comments ]
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <alpine.DEB.2.00.0905121431020.13338@gandalf.stny.rr.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/irq/manage.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 2734eca..eb47f8b 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -851,7 +851,7 @@ EXPORT_SYMBOL(free_irq);
* still called in hard interrupt context and has to check
* whether the interrupt originates from the device. If yes it
* needs to disable the interrupt on the device and return
- * IRQ_THREAD_WAKE which will wake up the handler thread and run
+ * IRQ_WAKE_THREAD which will wake up the handler thread and run
* @thread_fn. This split handler design is necessary to support
* shared interrupts.
*
prev parent reply other threads:[~2009-05-12 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 18:35 [PATCH] threaded-irqs: fix comment to say IRQ_WAKE_THREAD Steven Rostedt
2009-05-12 20:12 ` tip-bot for Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-39a2eddb9b62959dc55c6978b5eaeb3dd57c5ff2@git.kernel.org \
--to=rostedt@goodmis.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox