public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] threaded-irqs: fix comment to say IRQ_WAKE_THREAD
@ 2009-05-12 18:35 Steven Rostedt
  2009-05-12 20:12 ` [tip:irq/urgent] genirq: " tip-bot for Steven Rostedt
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2009-05-12 18:35 UTC (permalink / raw)
  To: LKML; +Cc: Thomas Gleixner, Ingo Molnar, Andrew Morton


Trying to implement a driver to use threaded irqs, I was confused when the 
return value to use that was described in the comment above 
request_threaded_irq was not defined.

Turns out that the enum is IRQ_WAKE_THREAD where as the comment said 
IRQ_THREAD_WAKE.

[Impact: do not confuse developers with wrong comments ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 2734eca..eb47f8b 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -851,7 +851,7 @@ EXPORT_SYMBOL(free_irq);
  *	still called in hard interrupt context and has to check
  *	whether the interrupt originates from the device. If yes it
  *	needs to disable the interrupt on the device and return
- *	IRQ_THREAD_WAKE which will wake up the handler thread and run
+ *	IRQ_WAKE_THREAD which will wake up the handler thread and run
  *	@thread_fn. This split handler design is necessary to support
  *	shared interrupts.
  *

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:irq/urgent] genirq: fix comment to say IRQ_WAKE_THREAD
  2009-05-12 18:35 [PATCH] threaded-irqs: fix comment to say IRQ_WAKE_THREAD Steven Rostedt
@ 2009-05-12 20:12 ` tip-bot for Steven Rostedt
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Steven Rostedt @ 2009-05-12 20:12 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, rostedt, tglx

Commit-ID:  39a2eddb9b62959dc55c6978b5eaeb3dd57c5ff2
Gitweb:     http://git.kernel.org/tip/39a2eddb9b62959dc55c6978b5eaeb3dd57c5ff2
Author:     Steven Rostedt <rostedt@goodmis.org>
AuthorDate: Tue, 12 May 2009 14:35:54 -0400
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 12 May 2009 22:11:29 +0200

genirq: fix comment to say IRQ_WAKE_THREAD

Trying to implement a driver to use threaded irqs, I was confused when the 
return value to use that was described in the comment above 
request_threaded_irq was not defined.

Turns out that the enum is IRQ_WAKE_THREAD where as the comment said 
IRQ_THREAD_WAKE.

[Impact: do not confuse developers with wrong comments ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <alpine.DEB.2.00.0905121431020.13338@gandalf.stny.rr.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>



---
 kernel/irq/manage.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 2734eca..eb47f8b 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -851,7 +851,7 @@ EXPORT_SYMBOL(free_irq);
  *	still called in hard interrupt context and has to check
  *	whether the interrupt originates from the device. If yes it
  *	needs to disable the interrupt on the device and return
- *	IRQ_THREAD_WAKE which will wake up the handler thread and run
+ *	IRQ_WAKE_THREAD which will wake up the handler thread and run
  *	@thread_fn. This split handler design is necessary to support
  *	shared interrupts.
  *

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-12 20:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-12 18:35 [PATCH] threaded-irqs: fix comment to say IRQ_WAKE_THREAD Steven Rostedt
2009-05-12 20:12 ` [tip:irq/urgent] genirq: " tip-bot for Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox