From: "tip-bot for H. Peter Anvin" <hpa@linux.intel.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, thomas@m3y3r.de, hpa@zytor.com,
mingo@redhat.com, chris@csamuel.org, tglx@linutronix.de,
hpa@linux.intel.com
Subject: [tip:x86/urgent] x86, setup: When probing memory with e801, use ax/bx as a pair
Date: Mon, 25 Apr 2011 23:25:02 GMT [thread overview]
Message-ID: <tip-39b68976ac653cfdc7f872a293e8b7928de2dcc6@git.kernel.org> (raw)
In-Reply-To: <1303566747.12067.10.camel@localhost.localdomain>
Commit-ID: 39b68976ac653cfdc7f872a293e8b7928de2dcc6
Gitweb: http://git.kernel.org/tip/39b68976ac653cfdc7f872a293e8b7928de2dcc6
Author: H. Peter Anvin <hpa@linux.intel.com>
AuthorDate: Mon, 25 Apr 2011 14:52:37 -0700
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Mon, 25 Apr 2011 14:52:37 -0700
x86, setup: When probing memory with e801, use ax/bx as a pair
When we use BIOS function e801 to probe memory, we should use ax/bx
(or cx/dx) as a pair, not mix and match. This was a typo during the
translation from assembly code, and breaks at least one set of
machines in the field (which return cx = dx = 0).
Reported-and-tested-by: Chris Samuel <chris@csamuel.org>
Fix-proposed-by: Thomas Meyer <thomas@m3y3r.de>
Link: http://lkml.kernel.org/r/1303566747.12067.10.camel@localhost.localdomain
---
arch/x86/boot/memory.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/boot/memory.c b/arch/x86/boot/memory.c
index cae3feb..db75d07 100644
--- a/arch/x86/boot/memory.c
+++ b/arch/x86/boot/memory.c
@@ -91,7 +91,7 @@ static int detect_memory_e801(void)
if (oreg.ax > 15*1024) {
return -1; /* Bogus! */
} else if (oreg.ax == 15*1024) {
- boot_params.alt_mem_k = (oreg.dx << 6) + oreg.ax;
+ boot_params.alt_mem_k = (oreg.bx << 6) + oreg.ax;
} else {
/*
* This ignores memory above 16MB if we have a memory
next prev parent reply other threads:[~2011-04-25 23:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 13:33 2.6.38.3 and 2.6.39-rc4 hangs after "Booting the kernel" on quad Pentium Pro system Chris Samuel
2011-04-22 13:46 ` Ingo Molnar
2011-04-22 19:09 ` Yinghai Lu
2011-04-22 19:29 ` Ingo Molnar
2011-04-22 19:46 ` Yinghai Lu
2011-04-23 0:20 ` Chris Samuel
2011-04-22 16:34 ` Alan Cox
2011-04-23 0:16 ` Chris Samuel
2011-04-23 1:28 ` Yuhong Bao
2011-04-23 1:35 ` Chris Samuel
2011-04-23 1:46 ` Yuhong Bao
2011-04-23 2:26 ` H. Peter Anvin
2011-04-23 2:31 ` Yuhong Bao
2011-04-23 4:33 ` Chris Samuel
2011-04-23 5:22 ` Chris Samuel
[not found] ` <SNT125-W25B0C502FF72465BC6B55BC3940@phx.gbl>
[not found] ` <201104231855.47680.chris@csamuel.org>
2011-04-23 10:47 ` FW: " Yuhong Bao
2011-04-23 13:52 ` Thomas Meyer
2011-04-23 17:51 ` H. Peter Anvin
2011-04-23 23:24 ` Chris Samuel
2011-04-24 0:16 ` Chris Samuel
2011-04-24 0:22 ` Chris Samuel
2011-04-24 8:46 ` Yinghai Lu
2011-04-25 11:13 ` Chris Samuel
2011-04-25 23:25 ` tip-bot for H. Peter Anvin [this message]
2011-04-26 4:50 ` [tip:x86/urgent] x86, setup: When probing memory with e801, use ax/bx as a pair Chris Samuel
2011-04-26 8:12 ` Ingo Molnar
2011-04-27 3:30 ` Chris Samuel
2011-05-05 11:57 ` Chris Samuel
2011-05-05 12:10 ` Ingo Molnar
2011-05-06 11:47 ` Chris Samuel
2011-05-06 12:04 ` Ingo Molnar
2011-05-06 12:10 ` Chris Samuel
2011-05-30 4:54 ` Yuhong Bao
2011-04-23 2:03 ` 2.6.38.3 and 2.6.39-rc4 hangs after "Booting the kernel" on quad Pentium Pro system H. Peter Anvin
2011-04-23 6:43 ` Chris Samuel
[not found] ` <1ac2dd46-0677-4be6-aca0-f8787da34cee@email.android.com>
2011-04-23 1:36 ` Chris Samuel
2011-04-23 9:35 ` Alan Cox
2011-04-23 10:35 ` Chris Samuel
2011-04-23 11:32 ` Chris Samuel
2011-04-23 13:11 ` Chris Samuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-39b68976ac653cfdc7f872a293e8b7928de2dcc6@git.kernel.org \
--to=hpa@linux.intel.com \
--cc=chris@csamuel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).