From: tip-bot for Ben Dooks <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
mingo@kernel.org, linux-arm-kernel@lists.infradead.org,
nicolas.ferre@atmel.com, hpa@zytor.com,
dinguyen@opensource.altera.com, daniel.lezcano@linaro.org,
ben.dooks@codethink.co.uk
Subject: [tip:timers/core] clocksource/drivers/dw_apb_timers_of: Fix IO endianness causing time jumps
Date: Tue, 31 Mar 2015 00:22:15 -0700 [thread overview]
Message-ID: <tip-3a10013b6a5975346fe5a8db59500a8d176d64e0@git.kernel.org> (raw)
In-Reply-To: <1427746633-9137-10-git-send-email-daniel.lezcano@linaro.org>
Commit-ID: 3a10013b6a5975346fe5a8db59500a8d176d64e0
Gitweb: http://git.kernel.org/tip/3a10013b6a5975346fe5a8db59500a8d176d64e0
Author: Ben Dooks <ben.dooks@codethink.co.uk>
AuthorDate: Mon, 30 Mar 2015 22:17:12 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 31 Mar 2015 09:15:57 +0200
clocksource/drivers/dw_apb_timers_of: Fix IO endianness causing time jumps
The dw_apb_timer_of timer is using __raw_readl() to access the
timer register, which is causing issues when the system is
running in big endian mode. Fix this by using readl_relaxed()
which should account for the endian settings.
This fixes issues where the time jumps around in the dmesg
output due to returnling __le32 values.
For an example, these two console lines show time running
backwards:
[ 49.882572] CPU1: failed to come online
[ 43.282457] Brought up 1 CPUs
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: digetx@gmail.com
Cc: hdegoede@redhat.com
Cc: laurent.pinchart+renesas@ideasonboard.com
Cc: maxime.ripard@free-electrons.com
Cc: viresh.kumar@linaro.org
Link: http://lkml.kernel.org/r/1427746633-9137-10-git-send-email-daniel.lezcano@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
drivers/clocksource/dw_apb_timer_of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
index d305fb0..a19a3f6 100644
--- a/drivers/clocksource/dw_apb_timer_of.c
+++ b/drivers/clocksource/dw_apb_timer_of.c
@@ -108,7 +108,7 @@ static void __init add_clocksource(struct device_node *source_timer)
static u64 notrace read_sched_clock(void)
{
- return ~__raw_readl(sched_io_base);
+ return ~readl_relaxed(sched_io_base);
}
static const struct of_device_id sptimer_ids[] __initconst = {
next prev parent reply other threads:[~2015-03-31 7:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 20:14 [GIT PULL] clockevents for 4.1 Daniel Lezcano
2015-03-30 20:17 ` [PATCH 01/11] clocksource: arm_arch_timer: Rename arch_timer_probed to reflect behaviour Daniel Lezcano
2015-03-30 20:17 ` [PATCH 02/11] clocksource: sun5i: Switch to request_irq Daniel Lezcano
2015-03-30 20:17 ` [PATCH 03/11] clocksource: sun5i: Use of_io_request_and_map Daniel Lezcano
2015-03-30 20:17 ` [PATCH 04/11] clocksource: sun5i: Remove sched_clock Daniel Lezcano
2015-03-30 20:17 ` [PATCH 05/11] clocksource: sun5i: Refactor the current code Daniel Lezcano
2015-03-30 20:17 ` [PATCH 06/11] clocksource: sun5i: Add clock notifiers Daniel Lezcano
2015-03-30 20:17 ` [PATCH 07/11] clocksource: at91: Make IO endian agnostic Daniel Lezcano
2015-03-31 7:23 ` [tip:timers/core] clocksource/drivers/at91: Fix IO endianness tip-bot for Ben Dooks
2015-03-30 20:17 ` [PATCH 08/11] clocksource: sun4i-timer: Only register a sched_clock on sun4i and sun5i Daniel Lezcano
2015-03-31 7:22 ` [tip:timers/core] clocksource/drivers/sun4i-timer: " tip-bot for Hans de Goede
2015-03-30 20:17 ` [PATCH 09/11] clocksource: tegra: Maintain CPU endianness Daniel Lezcano
2015-03-31 7:22 ` [tip:timers/core] clocksource/drivers/tegra: Fix IO endianness tip-bot for Dmitry Osipenko
2015-03-30 20:17 ` [PATCH 10/11] clocksource: dw_apb_timer_of: Make IO endian agnostic Daniel Lezcano
2015-03-31 7:22 ` tip-bot for Ben Dooks [this message]
2015-03-30 20:17 ` [PATCH 11/11] clocksource: efm32: Use CLOCK_EVT_FEAT_PERIODIC for defining features Daniel Lezcano
2015-03-31 7:21 ` [tip:timers/core] clocksource/drivers/efm32: " tip-bot for Viresh Kumar
2015-03-31 7:14 ` [PATCH 01/11] clocksource: arm_arch_timer: Rename arch_timer_probed to reflect behaviour Ingo Molnar
2015-03-31 14:14 ` Laurent Pinchart
2015-03-31 15:49 ` Ingo Molnar
2015-03-31 7:17 ` [GIT PULL] clockevents for 4.1 Ingo Molnar
2015-03-31 9:37 ` Daniel Lezcano
2015-03-31 9:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3a10013b6a5975346fe5a8db59500a8d176d64e0@git.kernel.org \
--to=tipbot@zytor.com \
--cc=ben.dooks@codethink.co.uk \
--cc=daniel.lezcano@linaro.org \
--cc=dinguyen@opensource.altera.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox