From: tip-bot for David Rientjes <rientjes@google.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, haicheng.li@linux.intel.com,
hpa@zytor.com, mingo@redhat.com, stable@kernel.org,
tglx@linutronix.de, rientjes@google.com
Subject: [tip:x86/urgent] x86: Set hotpluggable nodes in nodes_possible_map
Date: Sat, 23 Jan 2010 06:51:38 GMT [thread overview]
Message-ID: <tip-3a5fc0e40cb467e692737bc798bc99773c81e1e2@git.kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1001201152040.30528@chino.kir.corp.google.com>
Commit-ID: 3a5fc0e40cb467e692737bc798bc99773c81e1e2
Gitweb: http://git.kernel.org/tip/3a5fc0e40cb467e692737bc798bc99773c81e1e2
Author: David Rientjes <rientjes@google.com>
AuthorDate: Wed, 20 Jan 2010 12:10:47 -0800
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 23 Jan 2010 06:21:57 +0100
x86: Set hotpluggable nodes in nodes_possible_map
nodes_possible_map does not currently include nodes that have SRAT
entries that are all ACPI_SRAT_MEM_HOT_PLUGGABLE since the bit is
cleared in nodes_parsed if it does not have an online address range.
Unequivocally setting the bit in nodes_parsed is insufficient since
existing code, such as acpi_get_nodes(), assumes all nodes in the map
have online address ranges. In fact, all code using nodes_parsed
assumes such nodes represent an address range of online memory.
nodes_possible_map is created by unioning nodes_parsed and
cpu_nodes_parsed; the former represents nodes with online memory and
the latter represents memoryless nodes. We now set the bit for
hotpluggable nodes in cpu_nodes_parsed so that it also gets set in
nodes_possible_map.
[ hpa: Haicheng Li points out that this makes the naming of the
variable cpu_nodes_parsed somewhat counterintuitive. However, leave
it as is in the interest of keeping the pure bug fix patch small. ]
Signed-off-by: David Rientjes <rientjes@google.com>
Tested-by: Haicheng Li <haicheng.li@linux.intel.com>
LKML-Reference: <alpine.DEB.2.00.1001201152040.30528@chino.kir.corp.google.com>
Cc: <stable@kernel.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/mm/srat_64.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c
index a271241..28c6876 100644
--- a/arch/x86/mm/srat_64.c
+++ b/arch/x86/mm/srat_64.c
@@ -229,9 +229,11 @@ update_nodes_add(int node, unsigned long start, unsigned long end)
printk(KERN_ERR "SRAT: Hotplug zone not continuous. Partly ignored\n");
}
- if (changed)
+ if (changed) {
+ node_set(node, cpu_nodes_parsed);
printk(KERN_INFO "SRAT: hot plug zone found %Lx - %Lx\n",
nd->start, nd->end);
+ }
}
/* Callback for parsing of the Proximity Domain <-> Memory Area mappings */
prev parent reply other threads:[~2010-01-23 6:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 7:42 [PATCH] x86/mm/srat_64.c: nodes_parsed should include all nodes detected by ACPI Haicheng Li
2010-01-17 2:22 ` Haicheng Li
2010-01-17 21:53 ` David Rientjes
2010-01-18 6:30 ` Yinghai Lu
2010-01-18 10:43 ` David Rientjes
2010-01-19 11:08 ` Haicheng Li
2010-01-19 11:29 ` Haicheng Li
2010-01-19 23:30 ` David Rientjes
2010-01-20 16:40 ` Haicheng Li
2010-01-20 20:10 ` [patch] x86: set hotpluggable nodes in nodes_possible_map David Rientjes
2010-01-20 22:45 ` Yinghai Lu
2010-01-20 23:32 ` David Rientjes
2010-01-21 3:00 ` Haicheng Li
2010-01-21 2:58 ` Haicheng Li
2010-01-21 6:58 ` David Rientjes
2010-01-21 7:31 ` Haicheng Li
2010-01-21 7:50 ` David Rientjes
2010-01-21 8:33 ` Haicheng Li
2010-01-21 23:12 ` David Rientjes
2010-01-22 4:06 ` [PATCH] x86/mm/srat_64.c: make node_possible_map include hotpluggable node Haicheng Li
2010-01-22 7:33 ` H. Peter Anvin
2010-01-22 8:43 ` Haicheng Li
2010-01-22 10:14 ` H. Peter Anvin
2010-01-22 10:35 ` Haicheng Li
2010-01-22 11:15 ` [tip:x86/urgent] x86: Set hotpluggable nodes in nodes_possible_map tip-bot for David Rientjes
2010-01-23 6:51 ` tip-bot for David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3a5fc0e40cb467e692737bc798bc99773c81e1e2@git.kernel.org \
--to=rientjes@google.com \
--cc=haicheng.li@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox