From: Yinghai Lu <yinghai@kernel.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
yinghai@kernel.org, davem@davemloft.net, tj@kernel.org,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/urgent] x86: remove duplicated code with pcpu_need_numa()
Date: Thu, 2 Apr 2009 04:09:41 GMT [thread overview]
Message-ID: <tip-3de46fda4c104deef17ec70f85361f5c6b84ce0e@git.kernel.org> (raw)
In-Reply-To: <49D31770.9090502@kernel.org>
Commit-ID: 3de46fda4c104deef17ec70f85361f5c6b84ce0e
Gitweb: http://git.kernel.org/tip/3de46fda4c104deef17ec70f85361f5c6b84ce0e
Author: Yinghai Lu <yinghai@kernel.org>
AuthorDate: Wed, 1 Apr 2009 00:27:44 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Thu, 2 Apr 2009 06:08:05 +0200
x86: remove duplicated code with pcpu_need_numa()
Impact: clean up
those code pcpu_need_numa(), should be removed.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: David Miller <davem@davemloft.net>
LKML-Reference: <49D31770.9090502@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/setup_percpu.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c
index 876b127..3a97a4c 100644
--- a/arch/x86/kernel/setup_percpu.c
+++ b/arch/x86/kernel/setup_percpu.c
@@ -153,7 +153,6 @@ static struct page * __init pcpur_get_page(unsigned int cpu, int pageno)
static ssize_t __init setup_pcpu_remap(size_t static_size)
{
static struct vm_struct vm;
- pg_data_t *last;
size_t ptrs_size, dyn_size;
unsigned int cpu;
ssize_t ret;
@@ -165,19 +164,6 @@ static ssize_t __init setup_pcpu_remap(size_t static_size)
if (!cpu_has_pse || !pcpu_need_numa())
return -EINVAL;
- last = NULL;
- for_each_possible_cpu(cpu) {
- int node = early_cpu_to_node(cpu);
-
- if (node_online(node) && NODE_DATA(node) &&
- last && last != NODE_DATA(node))
- goto proceed;
-
- last = NODE_DATA(node);
- }
- return -EINVAL;
-
-proceed:
/*
* Currently supports only single page. Supporting multiple
* pages won't be too difficult if it ever becomes necessary.
next prev parent reply other threads:[~2009-04-02 4:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 5:31 Inverted NUMA test in setup_pcpu_remap()? David Miller
2009-04-01 5:56 ` Yinghai Lu
2009-04-01 6:06 ` [PATCH] x86,percpu: fix inverted NUMA test in setup_pcpu_remap() Tejun Heo
2009-04-01 7:27 ` [PATCH] x86: remove duplicated code with pcpu_need_numa() Yinghai Lu
2009-04-01 7:33 ` Tejun Heo
2009-04-01 8:04 ` David Miller
2009-04-02 4:09 ` Yinghai Lu [this message]
2009-04-02 4:09 ` [tip:x86/urgent] x86,percpu: fix inverted NUMA test in setup_pcpu_remap() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3de46fda4c104deef17ec70f85361f5c6b84ce0e@git.kernel.org \
--to=yinghai@kernel.org \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox