From: tip-bot for Ingo Molnar <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@kernel.org, a.p.zijlstra@chello.nl,
acme@ghostprotocols.net, namhyung@kernel.org, jolsa@redhat.com,
dsahern@gmail.com, tglx@linutronix.de
Subject: [tip:perf/core] tools/perf/build: Fix non-existent build directory handling
Date: Mon, 14 Oct 2013 22:33:54 -0700 [thread overview]
Message-ID: <tip-3fb66335e13ef7426affe9efa48c08857202c1cb@git.kernel.org> (raw)
In-Reply-To: <20131009150023.GA10167@gmail.com>
Commit-ID: 3fb66335e13ef7426affe9efa48c08857202c1cb
Gitweb: http://git.kernel.org/tip/3fb66335e13ef7426affe9efa48c08857202c1cb
Author: Ingo Molnar <mingo@kernel.org>
AuthorDate: Wed, 9 Oct 2013 17:00:23 +0200
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 14 Oct 2013 10:29:05 -0300
tools/perf/build: Fix non-existent build directory handling
Arnaldo reported that non-existent build directories were not
recognized properly. The reason is readlink failure causing 'O'
to become empty.
Solve it by passing through the 'O' variable unmodified if
readlink fails.
Reported-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/20131009150023.GA10167@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 5aa3d04..9147044 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -34,7 +34,7 @@ endif
# Only pass canonical directory names as the output directory:
#
ifneq ($(O),)
- FULL_O := $(shell readlink -f $(O))
+ FULL_O := $(shell readlink -f $(O) || echo $(O))
endif
define print_msg
next prev parent reply other threads:[~2013-10-15 5:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 7:01 [GIT PULL] tools/perf/build: Speed up the perf build system Ingo Molnar
2013-10-09 14:38 ` Arnaldo Carvalho de Melo
2013-10-09 14:51 ` Ingo Molnar
2013-10-09 15:00 ` [PATCH] tools/perf/build: Fix non-existent build directory handling Ingo Molnar
2013-10-15 5:33 ` tip-bot for Ingo Molnar [this message]
2013-10-09 19:16 ` [GIT PULL] tools/perf/build: Speed up the perf build system Arnaldo Carvalho de Melo
2013-10-09 19:38 ` Arnaldo Carvalho de Melo
2013-10-10 5:42 ` [PATCH] tools/perf/build: Fix redirection printouts Ingo Molnar
2013-10-15 5:31 ` [tip:perf/core] perf tools: " tip-bot for Ingo Molnar
2013-10-10 6:10 ` [PATCH] tools/perf/build: Pass through DEBUG parameter Ingo Molnar
2013-10-10 19:26 ` [GIT PULL] tools/perf/build: Speed up the perf build system Arnaldo Carvalho de Melo
2013-10-10 19:50 ` Arnaldo Carvalho de Melo
2013-10-10 20:06 ` Arnaldo Carvalho de Melo
2013-10-10 22:13 ` Jiri Olsa
2013-10-10 22:29 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-3fb66335e13ef7426affe9efa48c08857202c1cb@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox