From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754881AbbHCRGn (ORCPT ); Mon, 3 Aug 2015 13:06:43 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40354 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753466AbbHCRGk (ORCPT ); Mon, 3 Aug 2015 13:06:40 -0400 Date: Mon, 3 Aug 2015 10:05:59 -0700 From: tip-bot for Xunlei Pang Message-ID: Cc: rostedt@goodmis.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, juri.lelli@gmail.com, pang.xunlei@linaro.org, peterz@infradead.org, efault@gmx.de, hpa@zytor.com, torvalds@linux-foundation.org Reply-To: mingo@kernel.org, juri.lelli@gmail.com, rostedt@goodmis.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, efault@gmx.de, torvalds@linux-foundation.org, hpa@zytor.com, pang.xunlei@linaro.org, peterz@infradead.org In-Reply-To: <1435995563-3723-2-git-send-email-xlpang@126.com> References: <1435995563-3723-2-git-send-email-xlpang@126.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/deadline: Remove a redundant condition from task_woken_dl() Git-Commit-ID: 3fe33bcdd358dd8c641cf4d92c9d2d9972ca94dd X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 3fe33bcdd358dd8c641cf4d92c9d2d9972ca94dd Gitweb: http://git.kernel.org/tip/3fe33bcdd358dd8c641cf4d92c9d2d9972ca94dd Author: Xunlei Pang AuthorDate: Sat, 4 Jul 2015 15:39:23 +0800 Committer: Ingo Molnar CommitDate: Mon, 3 Aug 2015 12:21:20 +0200 sched/deadline: Remove a redundant condition from task_woken_dl() 'p' has been already queued at this point, so "!task_running(rq, p)" and "p->nr_cpus_allowed > 1" imply that "has_pushable_dl_tasks(rq)" is true, so it can be removed. Signed-off-by: Xunlei Pang Signed-off-by: Peter Zijlstra (Intel) Acked-by: Steven Rostedt Cc: Juri Lelli Cc: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/1435995563-3723-2-git-send-email-xlpang@126.com Signed-off-by: Ingo Molnar --- kernel/sched/deadline.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 0a17af35..20772ee 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -1657,7 +1657,6 @@ static void task_woken_dl(struct rq *rq, struct task_struct *p) { if (!task_running(rq, p) && !test_tsk_need_resched(rq->curr) && - has_pushable_dl_tasks(rq) && p->nr_cpus_allowed > 1 && dl_task(rq->curr) && (rq->curr->nr_cpus_allowed < 2 ||