public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Mathieu Poirier <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mathieu.poirier@linaro.org, torvalds@linux-foundation.org,
	tglx@linutronix.de, linux-kernel@vger.kernel.org,
	jolsa@redhat.com, alexander.shishkin@linux.intel.com,
	vincent.weaver@maine.edu, peterz@infradead.org, acme@redhat.com,
	mingo@kernel.org, hpa@zytor.com, eranian@google.com
Subject: [tip:perf/core] perf/core: Fix file name handling for start/stop filters
Date: Thu, 18 Aug 2016 03:51:16 -0700	[thread overview]
Message-ID: <tip-4059ffd09d694f704e18a4baf97fc0016c32e9ad@git.kernel.org> (raw)
In-Reply-To: <1468860187-318-2-git-send-email-mathieu.poirier@linaro.org>

Commit-ID:  4059ffd09d694f704e18a4baf97fc0016c32e9ad
Gitweb:     http://git.kernel.org/tip/4059ffd09d694f704e18a4baf97fc0016c32e9ad
Author:     Mathieu Poirier <mathieu.poirier@linaro.org>
AuthorDate: Mon, 18 Jul 2016 10:43:05 -0600
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 18 Aug 2016 10:35:50 +0200

perf/core: Fix file name handling for start/stop filters

Binary file names have to be supplied for both range and start/stop
filters but the current code only processes the filename if an
address range filter is specified.  This code adds processing of
the filename for start/stop filters.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: http://lkml.kernel.org/r/1468860187-318-2-git-send-email-mathieu.poirier@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/events/core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 6e454bf..52780ef 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7972,8 +7972,10 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
 					goto fail;
 			}
 
-			if (token == IF_SRC_FILE) {
-				filename = match_strdup(&args[2]);
+			if (token == IF_SRC_FILE || token == IF_SRC_FILEADDR) {
+				int fpos = filter->range ? 2 : 1;
+
+				filename = match_strdup(&args[fpos]);
 				if (!filename) {
 					ret = -ENOMEM;
 					goto fail;

  reply	other threads:[~2016-08-18 10:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 16:43 [PATCH V2 0/3] perf/core: Miscellaneous fix for address filtering Mathieu Poirier
2016-07-18 16:43 ` [PATCH V2 1/3] perf/core: Fixing filename for start/stop filters Mathieu Poirier
2016-08-18 10:51   ` tip-bot for Mathieu Poirier [this message]
2016-07-18 16:43 ` [PATCH V2 2/3] perf/core: Update filter only on executable mmap Mathieu Poirier
2016-08-18 10:51   ` [tip:perf/core] perf/core: Update filters " tip-bot for Mathieu Poirier
2016-07-18 16:43 ` [PATCH V2 3/3] perf/core: Enabling mapping of the stop filters Mathieu Poirier
2016-08-18 10:52   ` [tip:perf/core] perf/core: Enable " tip-bot for Mathieu Poirier
2016-07-19  7:30 ` [PATCH V2 0/3] perf/core: Miscellaneous fix for address filtering Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-4059ffd09d694f704e18a4baf97fc0016c32e9ad@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@redhat.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.weaver@maine.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox