From: "tip-bot for Eric W. Biederman" <ebiederm@xmission.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
tglx@linutronix.de, ebiederm@xmission.com
Subject: [tip:x86/irq] x86, acpi/irq: pci device dev->irq is an isa irq not a gsi
Date: Wed, 5 May 2010 02:07:21 GMT [thread overview]
Message-ID: <tip-414d3448dbcb40807a1265ace64b2576ef919fbe@git.kernel.org> (raw)
In-Reply-To: <1269936436-7039-3-git-send-email-ebiederm@xmission.com>
Commit-ID: 414d3448dbcb40807a1265ace64b2576ef919fbe
Gitweb: http://git.kernel.org/tip/414d3448dbcb40807a1265ace64b2576ef919fbe
Author: Eric W. Biederman <ebiederm@xmission.com>
AuthorDate: Tue, 30 Mar 2010 01:07:04 -0700
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Tue, 4 May 2010 13:34:30 -0700
x86, acpi/irq: pci device dev->irq is an isa irq not a gsi
Strictly speaking on x86 (where acpi is used) dev->irq must be
a dual i8259 irq input aka an isa irq. Therefore we should translate
that isa irq into a gsi before passing it to a function that
takes a gsi.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
LKML-Reference: <1269936436-7039-3-git-send-email-ebiederm@xmission.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
drivers/acpi/pci_irq.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
index b0a71ec..e4804fb 100644
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -401,11 +401,13 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
* driver reported one, then use it. Exit in any case.
*/
if (gsi < 0) {
+ u32 dev_gsi;
dev_warn(&dev->dev, "PCI INT %c: no GSI", pin_name(pin));
/* Interrupt Line values above 0xF are forbidden */
- if (dev->irq > 0 && (dev->irq <= 0xF)) {
- printk(" - using IRQ %d\n", dev->irq);
- acpi_register_gsi(&dev->dev, dev->irq,
+ if (dev->irq > 0 && (dev->irq <= 0xF) &&
+ (acpi_isa_irq_to_gsi(dev->irq, &dev_gsi) == 0)) {
+ printk(" - using ISA IRQ %d\n", dev->irq);
+ acpi_register_gsi(&dev->dev, dev_gsi,
ACPI_LEVEL_SENSITIVE,
ACPI_ACTIVE_LOW);
return 0;
next prev parent reply other threads:[~2010-05-05 2:08 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 1:36 [PATCH 00/10] x86/irq Yinghai Lu
2010-03-22 1:36 ` [PATCH 01/10] irq: move some interrupt arch_* functions into struct irq_chip Yinghai Lu
2010-03-22 1:56 ` Michael Ellerman
2010-03-22 3:32 ` Yinghai Lu
2010-03-23 7:10 ` Paul Mundt
2010-03-24 13:33 ` Ian Campbell
2010-03-22 10:19 ` Thomas Gleixner
2010-03-24 13:32 ` Ian Campbell
2010-03-24 17:44 ` Thomas Gleixner
2010-03-24 19:16 ` Ian Campbell
2010-03-24 21:25 ` Thomas Gleixner
2010-03-22 1:36 ` [PATCH 02/10] x86: fix out of order of gsi - full Yinghai Lu
2010-03-22 11:14 ` Thomas Gleixner
2010-03-22 19:45 ` Yinghai Lu
2010-03-29 13:40 ` Eric W. Biederman
2010-03-29 17:57 ` H. Peter Anvin
2010-03-29 23:19 ` [PATCH 0/14] Start coping gsis < 16 that are not isa irqs Eric W. Biederman
2010-03-29 23:20 ` [PATCH 01/14] x86 acpi/irq: Introduce apci_isa_irq_to_gsi Eric W. Biederman
2010-03-29 23:20 ` [PATCH 02/14] x86 acpi/irq: Teach acpi_get_override_irq to take a gsi not an isa_irq Eric W. Biederman
2010-03-29 23:20 ` [PATCH 03/14] x86 acpi/irq: pci device dev->irq is an isa irq not a gsi Eric W. Biederman
2010-03-29 23:20 ` [PATCH 04/14] x86 acpi/irq: Fix acpi_sci_ioapic_setup so it has both bus_irq and gsi Eric W. Biederman
2010-03-29 23:20 ` [PATCH 05/14] x86 acpi/irq: Generalize mp_config_acpi_legacy_irqs Eric W. Biederman
2010-03-29 23:20 ` [PATCH 06/14] x86 ioapic: Only export mp_find_ioapic and mp_find_ioapic_pin in io_apic.h Eric W. Biederman
2010-03-29 23:20 ` [PATCH 07/14] x86 ioapic: Fix the types of gsi values Eric W. Biederman
2010-03-29 23:20 ` [PATCH 08/14] x86 ioapic: Teach mp_register_ioapic to compute a global gsi_end Eric W. Biederman
2010-03-29 23:20 ` [PATCH 09/14] x86 ioapic: In mpparse use mp_register_ioapic Eric W. Biederman
2010-03-29 23:20 ` [PATCH 10/14] x86 ioapic: Move nr_ioapic_registers calculation to mp_register_ioapic Eric W. Biederman
2010-03-29 23:20 ` [PATCH 11/14] x86 ioapic: Optimize pin_2_irq Eric W. Biederman
2010-03-29 23:20 ` [PATCH 12/14] x86 ioapic: Simplify probe_nr_irqs_gsi Eric W. Biederman
2010-03-30 2:16 ` Yinghai Lu
2010-03-30 4:43 ` Eric W. Biederman
2010-03-30 4:55 ` Yinghai Lu
2010-03-30 5:41 ` Eric W. Biederman
2010-03-29 23:20 ` [PATCH 13/14] x86 acpi/irq: Handle isa irqs that are not identity mapped to gsi's Eric W. Biederman
2010-03-29 23:20 ` [PATCH 14/14] x86 irq: Kill io_apic_renumber_irq Eric W. Biederman
2010-03-30 8:06 ` [PATCH 0/15] Start coping gsis < 16 that are not isa irqs. v2 Eric W. Biederman
2010-03-30 8:07 ` [PATCH 01/15] x86 acpi/irq: Introduce apci_isa_irq_to_gsi Eric W. Biederman
2010-05-05 2:06 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 02/15] x86 acpi/irq: Teach acpi_get_override_irq to take a gsi not an isa_irq Eric W. Biederman
2010-05-05 2:07 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 03/15] x86 acpi/irq: pci device dev->irq is an isa irq not a gsi Eric W. Biederman
2010-05-05 2:07 ` tip-bot for Eric W. Biederman [this message]
2010-03-30 8:07 ` [PATCH 04/15] x86 acpi/irq: Fix acpi_sci_ioapic_setup so it has both bus_irq and gsi Eric W. Biederman
2010-05-05 2:07 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 05/15] x86 acpi/irq: Generalize mp_config_acpi_legacy_irqs Eric W. Biederman
2010-05-05 2:07 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 06/15] x86 ioapic: Only export mp_find_ioapic and mp_find_ioapic_pin in io_apic.h Eric W. Biederman
2010-05-05 2:08 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 07/15] x86 ioapic: Fix io_apic_redir_entries to return the number of entries Eric W. Biederman
2010-05-05 2:08 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 08/15] x86 ioapic: Fix the types of gsi values Eric W. Biederman
2010-05-05 2:08 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 09/15] x86 ioapic: Teach mp_register_ioapic to compute a global gsi_end Eric W. Biederman
2010-05-05 2:09 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 10/15] x86 ioapic: In mpparse use mp_register_ioapic Eric W. Biederman
2010-05-05 2:09 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 11/15] x86 ioapic: Move nr_ioapic_registers calculation to mp_register_ioapic Eric W. Biederman
2010-05-05 2:09 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 12/15] x86 ioapic: Optimize pin_2_irq Eric W. Biederman
2010-05-05 2:09 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 13/15] x86 ioapic: Simplify probe_nr_irqs_gsi Eric W. Biederman
2010-05-05 2:10 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 14/15] x86 acpi/irq: Handle isa irqs that are not identity mapped to gsi's Eric W. Biederman
2010-05-05 2:10 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-05-05 7:49 ` Yinghai
2010-05-05 8:53 ` [PATCH] x86 acpi/irq: Fix harmless typo Eric W. Biederman
2010-05-05 8:58 ` Ingo Molnar
2010-05-05 9:32 ` [tip:x86/irq] x86, acpi/irq: Handle isa irqs that are not identity mapped to gsi's Eric W. Biederman
2010-06-07 21:05 ` H. Peter Anvin
2010-06-08 22:20 ` Yinghai Lu
2010-05-05 8:56 ` Ingo Molnar
2010-05-05 9:36 ` Eric Biederman
2010-05-05 10:05 ` Ingo Molnar
2010-05-05 20:22 ` [PATCH] x86 acpi/irq: Define gsi_end when X86_IO_APIC is undefined Eric W. Biederman
2010-05-06 6:18 ` Ingo Molnar
2010-05-06 10:07 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-03-30 8:07 ` [PATCH 15/15] x86 irq: Kill io_apic_renumber_irq Eric W. Biederman
2010-05-05 2:10 ` [tip:x86/irq] x86, " tip-bot for Eric W. Biederman
2010-05-03 23:21 ` [PATCH 0/15] Start coping gsis < 16 that are not isa irqs. v2 Eric W. Biederman
2010-04-01 2:02 ` [PATCH 0/14] Start coping gsis < 16 that are not isa irqs Len Brown
2010-04-01 3:31 ` Eric W. Biederman
2010-03-22 1:36 ` [PATCH 03/10] x86: set nr_irqs_gsi only in probe_nr_irqs_gsi Yinghai Lu
2010-03-22 1:36 ` [PATCH 04/10] x86: kill smpboot_hooks.h Yinghai Lu
2010-03-22 13:34 ` Thomas Gleixner
2010-03-22 1:36 ` [PATCH 05/10] x86: use vector_desc instead of vector_irq Yinghai Lu
2010-03-22 13:58 ` Thomas Gleixner
2010-03-22 14:04 ` Eric W. Biederman
2010-03-22 14:16 ` Thomas Gleixner
2010-03-22 1:36 ` [PATCH 06/10] irq: Start the transition of irq_chip methods taking a desc Yinghai Lu
2010-03-22 1:36 ` [PATCH 07/10] x86/irq: use irq_desc *desc with irq_chip Yinghai Lu
2010-03-22 1:36 ` [PATCH 08/10] genericirq: add set_irq_desc_chip/data Yinghai Lu
2010-03-22 1:36 ` [PATCH 09/10] x86/iommu/dmar: update iommu/inter_remapping to use desc Yinghai Lu
2010-03-22 1:36 ` [PATCH 10/10] x86: remove arch_probe_nr_irqs Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-414d3448dbcb40807a1265ace64b2576ef919fbe@git.kernel.org \
--to=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).