public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Kirill Tkhai <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: torvalds@linux-foundation.org, peterz@infradead.org,
	mingo@kernel.org, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, efault@gmx.de, hpa@zytor.com,
	ktkhai@odin.com
Subject: [tip:sched/core] sched/core: Delete PF_EXITING checks from cpu_cgroup_exit() callback
Date: Sun, 13 Sep 2015 04:01:14 -0700	[thread overview]
Message-ID: <tip-446685e9bfa11174332fbb0b3218b37015fbf4ff@git.kernel.org> (raw)
In-Reply-To: <55E444C8.3020402@odin.com>

Commit-ID:  446685e9bfa11174332fbb0b3218b37015fbf4ff
Gitweb:     http://git.kernel.org/tip/446685e9bfa11174332fbb0b3218b37015fbf4ff
Author:     Kirill Tkhai <ktkhai@odin.com>
AuthorDate: Mon, 31 Aug 2015 15:12:56 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Sun, 13 Sep 2015 09:52:51 +0200

sched/core: Delete PF_EXITING checks from cpu_cgroup_exit() callback

cgroup_exit() is not called from copy_process() after commit:

  e8604cb43690 ("cgroup: fix spurious lockdep warning in cgroup_exit()")

from do_exit(). So this check is useless and the comment is obsolete.

Signed-off-by: Kirill Tkhai <ktkhai@odin.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/55E444C8.3020402@odin.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/core.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 7c099e6..37ab6f9 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8193,14 +8193,6 @@ static void cpu_cgroup_exit(struct cgroup_subsys_state *css,
 			    struct cgroup_subsys_state *old_css,
 			    struct task_struct *task)
 {
-	/*
-	 * cgroup_exit() is called in the copy_process() failure path.
-	 * Ignore this case since the task hasn't ran yet, this avoids
-	 * trying to poke a half freed task state from generic code.
-	 */
-	if (!(task->flags & PF_EXITING))
-		return;
-
 	sched_move_task(task);
 }
 

  parent reply	other threads:[~2015-09-13 11:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 11:49 [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks Kirill Tkhai
2015-08-31 11:53 ` Peter Zijlstra
2015-08-31 12:12   ` Kirill Tkhai
2015-08-31 13:37     ` Peter Zijlstra
2015-09-13 11:01     ` tip-bot for Kirill Tkhai [this message]
2015-09-13 11:09     ` [tip:perf/core] perf/core: Delete PF_EXITING checks from perf_cgroup_exit() callback tip-bot for Kirill Tkhai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-446685e9bfa11174332fbb0b3218b37015fbf4ff@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=efault@gmx.de \
    --cc=hpa@zytor.com \
    --cc=ktkhai@odin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox