From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754496AbbIMLBx (ORCPT ); Sun, 13 Sep 2015 07:01:53 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43406 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbbIMLBv (ORCPT ); Sun, 13 Sep 2015 07:01:51 -0400 Date: Sun, 13 Sep 2015 04:01:14 -0700 From: tip-bot for Kirill Tkhai Message-ID: Cc: torvalds@linux-foundation.org, peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, efault@gmx.de, hpa@zytor.com, ktkhai@odin.com Reply-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, torvalds@linux-foundation.org, peterz@infradead.org, ktkhai@odin.com, efault@gmx.de, hpa@zytor.com In-Reply-To: <55E444C8.3020402@odin.com> References: <55E444C8.3020402@odin.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched/core: Delete PF_EXITING checks from cpu_cgroup_exit() callback Git-Commit-ID: 446685e9bfa11174332fbb0b3218b37015fbf4ff X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 446685e9bfa11174332fbb0b3218b37015fbf4ff Gitweb: http://git.kernel.org/tip/446685e9bfa11174332fbb0b3218b37015fbf4ff Author: Kirill Tkhai AuthorDate: Mon, 31 Aug 2015 15:12:56 +0300 Committer: Ingo Molnar CommitDate: Sun, 13 Sep 2015 09:52:51 +0200 sched/core: Delete PF_EXITING checks from cpu_cgroup_exit() callback cgroup_exit() is not called from copy_process() after commit: e8604cb43690 ("cgroup: fix spurious lockdep warning in cgroup_exit()") from do_exit(). So this check is useless and the comment is obsolete. Signed-off-by: Kirill Tkhai Signed-off-by: Peter Zijlstra (Intel) Cc: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/55E444C8.3020402@odin.com Signed-off-by: Ingo Molnar --- kernel/sched/core.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 7c099e6..37ab6f9 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -8193,14 +8193,6 @@ static void cpu_cgroup_exit(struct cgroup_subsys_state *css, struct cgroup_subsys_state *old_css, struct task_struct *task) { - /* - * cgroup_exit() is called in the copy_process() failure path. - * Ignore this case since the task hasn't ran yet, this avoids - * trying to poke a half freed task state from generic code. - */ - if (!(task->flags & PF_EXITING)) - return; - sched_move_task(task); }