From: tip-bot for Leo Yan <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mathieu.poirier@linaro.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
robert.walker@arm.com, suzuki.poulose@arm.com,
mike.leach@linaro.org, jolsa@redhat.com, acme@redhat.com,
namhyung@kernel.org, alexander.shishkin@linux.intel.com,
leo.yan@linaro.org, hpa@zytor.com, coresight@lists.linaro.org
Subject: [tip:perf/core] perf cs-etm: Add exception number in exception packet
Date: Sat, 9 Feb 2019 04:53:31 -0800 [thread overview]
Message-ID: <tip-47106e7413f9fc10780d1ec7df3eaa725df6ebe8@git.kernel.org> (raw)
In-Reply-To: <20190129122842.32041-5-leo.yan@linaro.org>
Commit-ID: 47106e7413f9fc10780d1ec7df3eaa725df6ebe8
Gitweb: https://git.kernel.org/tip/47106e7413f9fc10780d1ec7df3eaa725df6ebe8
Author: Leo Yan <leo.yan@linaro.org>
AuthorDate: Tue, 29 Jan 2019 20:28:38 +0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 6 Feb 2019 10:00:40 -0300
perf cs-etm: Add exception number in exception packet
When an exception packet comes, it contains the information for
exception number; the exception number indicates the exception types, so
from it we can know if the exception is taken for interrupt, system call
or other traps, etc.
This patch simply adds a field in cs_etm_packet struct, it records
exception number for exception packet that will then be used to properly
identify exception types to the perf synthesize mechanic.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Robert Walker <robert.walker@arm.com>
Cc: Suzuki K Poulouse <suzuki.poulose@arm.com>
Cc: coresight ml <coresight@lists.linaro.org>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/20190129122842.32041-5-leo.yan@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 20 ++++++++++++++++----
tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 1 +
2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
index e98ee49a1527..294efa76c9e3 100644
--- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
+++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
@@ -294,6 +294,7 @@ static void cs_etm_decoder__clear_buffer(struct cs_etm_decoder *decoder)
decoder->packet_buffer[i].last_instr_subtype = 0;
decoder->packet_buffer[i].last_instr_cond = 0;
decoder->packet_buffer[i].flags = 0;
+ decoder->packet_buffer[i].exception_number = UINT32_MAX;
decoder->packet_buffer[i].cpu = INT_MIN;
}
}
@@ -331,6 +332,7 @@ cs_etm_decoder__buffer_packet(struct cs_etm_decoder *decoder,
decoder->packet_buffer[et].last_instr_subtype = 0;
decoder->packet_buffer[et].last_instr_cond = 0;
decoder->packet_buffer[et].flags = 0;
+ decoder->packet_buffer[et].exception_number = UINT32_MAX;
if (decoder->packet_count == MAX_BUFFER - 1)
return OCSD_RESP_WAIT;
@@ -406,10 +408,20 @@ cs_etm_decoder__buffer_discontinuity(struct cs_etm_decoder *decoder,
static ocsd_datapath_resp_t
cs_etm_decoder__buffer_exception(struct cs_etm_decoder *decoder,
+ const ocsd_generic_trace_elem *elem,
const uint8_t trace_chan_id)
-{
- return cs_etm_decoder__buffer_packet(decoder, trace_chan_id,
- CS_ETM_EXCEPTION);
+{ int ret = 0;
+ struct cs_etm_packet *packet;
+
+ ret = cs_etm_decoder__buffer_packet(decoder, trace_chan_id,
+ CS_ETM_EXCEPTION);
+ if (ret != OCSD_RESP_CONT && ret != OCSD_RESP_WAIT)
+ return ret;
+
+ packet = &decoder->packet_buffer[decoder->tail];
+ packet->exception_number = elem->exception_number;
+
+ return ret;
}
static ocsd_datapath_resp_t
@@ -443,7 +455,7 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer(
trace_chan_id);
break;
case OCSD_GEN_TRC_ELEM_EXCEPTION:
- resp = cs_etm_decoder__buffer_exception(decoder,
+ resp = cs_etm_decoder__buffer_exception(decoder, elem,
trace_chan_id);
break;
case OCSD_GEN_TRC_ELEM_EXCEPTION_RET:
diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
index 23600e57a215..012b4728a46f 100644
--- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
+++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
@@ -46,6 +46,7 @@ struct cs_etm_packet {
u32 last_instr_type;
u32 last_instr_subtype;
u32 flags;
+ u32 exception_number;
u8 last_instr_cond;
u8 last_instr_taken_branch;
u8 last_instr_size;
next prev parent reply other threads:[~2019-02-09 12:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 12:28 [PATCH v7 0/8] perf cs-etm: Add support for sample flags Leo Yan
2019-01-29 12:28 ` [PATCH v7 1/8] perf cs-etm: Add last instruction information in packet Leo Yan
2019-02-09 12:51 ` [tip:perf/core] " tip-bot for Leo Yan
2019-01-29 12:28 ` [PATCH v7 2/8] perf cs-etm: Set sample flags for instruction range packet Leo Yan
2019-02-09 12:52 ` [tip:perf/core] " tip-bot for Leo Yan
2019-01-29 12:28 ` [PATCH v7 3/8] perf cs-etm: Set sample flags for trace discontinuity Leo Yan
2019-02-09 12:52 ` [tip:perf/core] " tip-bot for Leo Yan
2019-01-29 12:28 ` [PATCH v7 4/8] perf cs-etm: Add exception number in exception packet Leo Yan
2019-02-09 12:53 ` tip-bot for Leo Yan [this message]
2019-01-29 12:28 ` [PATCH v7 5/8] perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata Leo Yan
2019-02-09 12:54 ` [tip:perf/core] " tip-bot for Leo Yan
2019-01-29 12:28 ` [PATCH v7 6/8] perf cs-etm: Add traceID in packet Leo Yan
2019-02-09 12:54 ` [tip:perf/core] " tip-bot for Leo Yan
2019-01-29 12:28 ` [PATCH v7 7/8] perf cs-etm: Set sample flags for exception packet Leo Yan
2019-02-09 12:55 ` [tip:perf/core] " tip-bot for Leo Yan
2019-01-29 12:28 ` [PATCH v7 8/8] perf cs-etm: Set sample flags for exception return packet Leo Yan
2019-02-09 12:56 ` [tip:perf/core] " tip-bot for Leo Yan
2019-02-04 18:41 ` [PATCH v7 0/8] perf cs-etm: Add support for sample flags Mathieu Poirier
2019-02-04 19:27 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-47106e7413f9fc10780d1ec7df3eaa725df6ebe8@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=robert.walker@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox