public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Daniel Lezcano <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	peterz@infradead.org, tglx@linutronix.de,
	daniel.lezcano@linaro.org
Subject: [tip:sched/core] sched: Reduce nohz_kick_needed() parameters
Date: Mon, 13 Jan 2014 07:55:39 -0800	[thread overview]
Message-ID: <tip-4a725627f21df6b280a19f50bc849daaab3b1544@git.kernel.org> (raw)
In-Reply-To: <1389008085-9069-3-git-send-email-daniel.lezcano@linaro.org>

Commit-ID:  4a725627f21df6b280a19f50bc849daaab3b1544
Gitweb:     http://git.kernel.org/tip/4a725627f21df6b280a19f50bc849daaab3b1544
Author:     Daniel Lezcano <daniel.lezcano@linaro.org>
AuthorDate: Mon, 6 Jan 2014 12:34:39 +0100
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 13 Jan 2014 13:47:27 +0100

sched: Reduce nohz_kick_needed() parameters

The cpu information is already stored in the struct rq, so no need to pass it
as parameter to the nohz_kick_needed function.

The caller of this function just called idle_cpu() before to fill the
rq->idle_balance field.

Use rq->cpu and rq->idle_balance.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1389008085-9069-3-git-send-email-daniel.lezcano@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/fair.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index b35d322..c47b1ce 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6788,14 +6788,14 @@ end:
  *   - For SD_ASYM_PACKING, if the lower numbered cpu's in the scheduler
  *     domain span are idle.
  */
-static inline int nohz_kick_needed(struct rq *rq, int cpu)
+static inline int nohz_kick_needed(struct rq *rq)
 {
 	unsigned long now = jiffies;
 	struct sched_domain *sd;
 	struct sched_group_power *sgp;
-	int nr_busy;
+	int nr_busy, cpu = rq->cpu;
 
-	if (unlikely(idle_cpu(cpu)))
+	if (unlikely(rq->idle_balance))
 		return 0;
 
        /*
@@ -6885,7 +6885,7 @@ void trigger_load_balance(struct rq *rq)
 	    likely(!on_null_domain(cpu)))
 		raise_softirq(SCHED_SOFTIRQ);
 #ifdef CONFIG_NO_HZ_COMMON
-	if (nohz_kick_needed(rq, cpu) && likely(!on_null_domain(cpu)))
+	if (nohz_kick_needed(rq) && likely(!on_null_domain(cpu)))
 		nohz_balancer_kick(cpu);
 #endif
 }

  reply	other threads:[~2014-01-13 15:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 11:34 [PATCH V2 0/8] sched: cleanup trigger_load_balance Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 1/8] sched: reduce trigger_load_balance parameters Daniel Lezcano
2014-01-13 15:55   ` [tip:sched/core] sched: Reduce trigger_load_balance() parameters tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 2/8] sched: reduce nohz_kick_needed parameters Daniel Lezcano
2014-01-13 15:55   ` tip-bot for Daniel Lezcano [this message]
2014-01-06 11:34 ` [PATCH V2 3/8] sched: pass struct rq to on_null_domain function Daniel Lezcano
2014-01-13 15:55   ` [tip:sched/core] sched: Pass 'struct rq' to on_null_domain() tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 4/8] sched: remove unused parameter for find_new_ilb Daniel Lezcano
2014-01-13 15:55   ` [tip:sched/core] sched: Remove unused parameter from find_new_ilb () tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 5/8] sched: remove unused parameter in nohz_balancer_kick function Daniel Lezcano
2014-01-13 15:56   ` [tip:sched/core] sched: Remove unused parameter from nohz_balancer_kick() tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 6/8] sched: pass struct rq to rebalance_domains function Daniel Lezcano
2014-01-13 15:56   ` [tip:sched/core] sched: Pass 'struct rq' to rebalance_domains() tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 7/8] sched: pass struct rq to nohz_idle_balance function Daniel Lezcano
2014-01-13 15:56   ` [tip:sched/core] sched: Pass 'struct rq' to nohz_idle_balance() tip-bot for Daniel Lezcano
2014-01-06 11:34 ` [PATCH V2 8/8] sched: factor out on_null_domain check in trigger_load_balance function Daniel Lezcano
2014-01-13 15:56   ` [tip:sched/core] sched: Factor out the on_null_domain() checks in trigger_load_balance() tip-bot for Daniel Lezcano
2014-01-06 12:32 ` [PATCH V2 0/8] sched: cleanup trigger_load_balance Peter Zijlstra
2014-01-13 12:55   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-4a725627f21df6b280a19f50bc849daaab3b1544@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox