From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbcBHOHl (ORCPT ); Mon, 8 Feb 2016 09:07:41 -0500 Received: from terminus.zytor.com ([198.137.202.10]:52140 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbcBHOHi (ORCPT ); Mon, 8 Feb 2016 09:07:38 -0500 Date: Mon, 8 Feb 2016 06:07:18 -0800 From: tip-bot for Milo Kim Message-ID: Cc: hpa@zytor.com, mingo@kernel.org, boris.brezillon@free-electrons.com, milo.kim@ti.com, jason@lakedaemon.net, ludovic.desroches@atmel.com, nicolas.ferre@atmel.com, tglx@linutronix.de, marc.zyngier@arm.com, linux-kernel@vger.kernel.org Reply-To: milo.kim@ti.com, boris.brezillon@free-electrons.com, mingo@kernel.org, hpa@zytor.com, jason@lakedaemon.net, tglx@linutronix.de, marc.zyngier@arm.com, nicolas.ferre@atmel.com, ludovic.desroches@atmel.com, linux-kernel@vger.kernel.org In-Reply-To: <1452669592-3401-4-git-send-email-milo.kim@ti.com> References: <1452669592-3401-4-git-send-email-milo.kim@ti.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/core] irqchip/atmel-aic: Remove duplicate bit operation Git-Commit-ID: 4b5ce20b5429eb08ae0776962a4aff7f00017800 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 4b5ce20b5429eb08ae0776962a4aff7f00017800 Gitweb: http://git.kernel.org/tip/4b5ce20b5429eb08ae0776962a4aff7f00017800 Author: Milo Kim AuthorDate: Wed, 13 Jan 2016 16:19:52 +0900 Committer: Thomas Gleixner CommitDate: Mon, 8 Feb 2016 15:03:42 +0100 irqchip/atmel-aic: Remove duplicate bit operation AIC5 priority value is updated twice - in aic_common_set_priority() and when updating AT91_AIC5_SMR. Variable, 'smr' has updated priority value (intspec[2]) in the first step, so no need to update it again in the second step. Signed-off-by: Milo Kim Acked-by: Boris Brezillon Cc: Jason Cooper Cc: Marc Zyngier Cc: Ludovic Desroches Cc: Nicholas Ferre Link: http://lkml.kernel.org/r/1452669592-3401-4-git-send-email-milo.kim@ti.com Signed-off-by: Thomas Gleixner --- drivers/irqchip/irq-atmel-aic5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c index f36f426..4f0d068 100644 --- a/drivers/irqchip/irq-atmel-aic5.c +++ b/drivers/irqchip/irq-atmel-aic5.c @@ -273,7 +273,7 @@ static int aic5_irq_domain_xlate(struct irq_domain *d, irq_reg_writel(bgc, *out_hwirq, AT91_AIC5_SSR); smr = irq_reg_readl(bgc, AT91_AIC5_SMR); aic_common_set_priority(intspec[2], &smr); - irq_reg_writel(bgc, intspec[2] | smr, AT91_AIC5_SMR); + irq_reg_writel(bgc, smr, AT91_AIC5_SMR); irq_gc_unlock(bgc); return ret;