From: tip-bot for Viresh Kumar <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: viresh.kumar@linaro.org, peterz@infradead.org,
vincent.guittot@linaro.org, mingo@kernel.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
hpa@zytor.com
Subject: [tip:sched/core] sched/topology: Drop memset() from init_rootdomain()
Date: Thu, 10 Aug 2017 05:05:38 -0700 [thread overview]
Message-ID: <tip-4d13a06d54c415238325b0fe2c14f1052da4512f@git.kernel.org> (raw)
In-Reply-To: <fc2f6cc90b098040970c85a97046512572d765bc.1492065513.git.viresh.kumar@linaro.org>
Commit-ID: 4d13a06d54c415238325b0fe2c14f1052da4512f
Gitweb: http://git.kernel.org/tip/4d13a06d54c415238325b0fe2c14f1052da4512f
Author: Viresh Kumar <viresh.kumar@linaro.org>
AuthorDate: Thu, 13 Apr 2017 14:45:48 +0530
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 10 Aug 2017 12:18:13 +0200
sched/topology: Drop memset() from init_rootdomain()
There are only two callers of init_rootdomain(). One of them passes a
global to it and another one sends dynamically allocated root-domain.
There is no need to memset the root-domain in the first case as the
structure is already reset.
Update alloc_rootdomain() to allocate the memory with kzalloc() and
remove the memset() call from init_rootdomain().
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linaro-kernel@lists.linaro.org
Link: http://lkml.kernel.org/r/fc2f6cc90b098040970c85a97046512572d765bc.1492065513.git.viresh.kumar@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/topology.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 79895ae..216fee0 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -261,8 +261,6 @@ void rq_attach_root(struct rq *rq, struct root_domain *rd)
static int init_rootdomain(struct root_domain *rd)
{
- memset(rd, 0, sizeof(*rd));
-
if (!zalloc_cpumask_var(&rd->span, GFP_KERNEL))
goto out;
if (!zalloc_cpumask_var(&rd->online, GFP_KERNEL))
@@ -311,7 +309,7 @@ static struct root_domain *alloc_rootdomain(void)
{
struct root_domain *rd;
- rd = kmalloc(sizeof(*rd), GFP_KERNEL);
+ rd = kzalloc(sizeof(*rd), GFP_KERNEL);
if (!rd)
return NULL;
next prev parent reply other threads:[~2017-08-10 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 9:15 [PATCH V2 0/3] sched: Minor cleanups Viresh Kumar
2017-04-13 9:15 ` [PATCH V2 1/3] sched: topology: drop memset() from init_rootdomain() Viresh Kumar
2017-08-10 12:05 ` tip-bot for Viresh Kumar [this message]
2017-04-13 9:15 ` [PATCH V2 2/3] sched: cpudeadline: don't re-initialize struct cpudl Viresh Kumar
2017-08-10 12:06 ` [tip:sched/core] sched/deadline: Don't re-initialize 'struct cpudl' tip-bot for Viresh Kumar
2017-04-13 9:15 ` [PATCH V2 3/3] sched: cpupri: don't re-initialize struct cpupri Viresh Kumar
2017-08-10 12:06 ` [tip:sched/core] sched/cpupri: Don't re-initialize 'struct cpupri' tip-bot for Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-4d13a06d54c415238325b0fe2c14f1052da4512f@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox