From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754506AbaESNK1 (ORCPT ); Mon, 19 May 2014 09:10:27 -0400 Received: from terminus.zytor.com ([198.137.202.10]:59418 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbaESNKY (ORCPT ); Mon, 19 May 2014 09:10:24 -0400 Date: Mon, 19 May 2014 06:09:16 -0700 From: tip-bot for Dietmar Eggemann Message-ID: Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, dietmar.eggemann@arm.com, Dietmar.Eggemann@arm.com, tglx@linutronix.de Reply-To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, Dietmar.Eggemann@arm.com, dietmar.eggemann@arm.com, peterz@infradead.org, tglx@linutronix.de In-Reply-To: <1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com> References: <1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:sched/core] sched: Do not zero sg->cpumask and sg->sgp-> power in build_sched_groups Git-Commit-ID: 4d65f453eb2c8f3dd9fc437c9a736c42ddbd50bd X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 4d65f453eb2c8f3dd9fc437c9a736c42ddbd50bd Gitweb: http://git.kernel.org/tip/4d65f453eb2c8f3dd9fc437c9a736c42ddbd50bd Author: Dietmar Eggemann AuthorDate: Wed, 30 Apr 2014 14:39:38 +0100 Committer: Thomas Gleixner CommitDate: Mon, 19 May 2014 22:02:41 +0900 sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups There is no need to zero struct sched_group member cpumask and struct sched_group_power member power since both structures are already allocated as zeroed memory in __sdt_alloc(). This patch has been tested with BUG_ON(!cpumask_empty(sched_group_cpus(sg))); and BUG_ON(sg->sgp->power); in build_sched_groups() on ARM TC2 and INTEL i5 M520 platform including CPU hotplug scenarios. Signed-off-by: Dietmar Eggemann Signed-off-by: Peter Zijlstra Link: http://lkml.kernel.org/r/1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com Signed-off-by: Thomas Gleixner --- kernel/sched/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index ca76cc6..354cd5a 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5794,8 +5794,6 @@ build_sched_groups(struct sched_domain *sd, int cpu) continue; group = get_group(i, sdd, &sg); - cpumask_clear(sched_group_cpus(sg)); - sg->sgp->power = 0; cpumask_setall(sched_group_mask(sg)); for_each_cpu(j, span) {