From: tip-bot for Numfor Mbiziwo-Tiapo <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mbd@fb.com, linux-kernel@vger.kernel.org, mingo@kernel.org,
namhyung@kernel.org, hpa@zytor.com, irogers@google.com,
alexander.shishkin@linux.intel.com, songliubraving@fb.com,
tglx@linutronix.de, eranian@google.com, jolsa@redhat.com,
acme@redhat.com, peterz@infradead.org, nums@google.com
Subject: [tip:perf/urgent] perf test mmap-thread-lookup: Initialize variable to suppress memory sanitizer warning
Date: Sat, 13 Jul 2019 03:52:23 -0700 [thread overview]
Message-ID: <tip-4e4cf62b37da5ff45c904a3acf242ab29ed5881d@git.kernel.org> (raw)
In-Reply-To: <20190702173716.181223-1-nums@google.com>
Commit-ID: 4e4cf62b37da5ff45c904a3acf242ab29ed5881d
Gitweb: https://git.kernel.org/tip/4e4cf62b37da5ff45c904a3acf242ab29ed5881d
Author: Numfor Mbiziwo-Tiapo <nums@google.com>
AuthorDate: Tue, 2 Jul 2019 10:37:15 -0700
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 9 Jul 2019 09:33:54 -0300
perf test mmap-thread-lookup: Initialize variable to suppress memory sanitizer warning
Running the 'perf test' command after building perf with a memory
sanitizer causes a warning that says:
WARNING: MemorySanitizer: use-of-uninitialized-value... in mmap-thread-lookup.c
Initializing the go variable to 0 silences this harmless warning.
Committer warning:
This was harmless, just a simple test writing whatever was at that
sizeof(int) memory area just to signal another thread blocked reading
that file created with pipe(). Initialize it tho so that we don't get
this warning.
Signed-off-by: Numfor Mbiziwo-Tiapo <nums@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Drayton <mbd@fb.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20190702173716.181223-1-nums@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/tests/mmap-thread-lookup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/mmap-thread-lookup.c b/tools/perf/tests/mmap-thread-lookup.c
index ba87e6e8d18c..0a4301a5155c 100644
--- a/tools/perf/tests/mmap-thread-lookup.c
+++ b/tools/perf/tests/mmap-thread-lookup.c
@@ -53,7 +53,7 @@ static void *thread_fn(void *arg)
{
struct thread_data *td = arg;
ssize_t ret;
- int go;
+ int go = 0;
if (thread_init(td))
return NULL;
prev parent reply other threads:[~2019-07-13 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 17:37 [PATCH 1/2] Fix mmap-thread-lookup.c unitialized memory usage Numfor Mbiziwo-Tiapo
2019-07-02 17:37 ` [PATCH 2/2] Fix perf-hooks test Numfor Mbiziwo-Tiapo
2019-07-05 16:40 ` Arnaldo Carvalho de Melo
2019-07-03 3:09 ` [PATCH 1/2] Fix mmap-thread-lookup.c unitialized memory usage Arnaldo Carvalho de Melo
2019-07-13 10:52 ` tip-bot for Numfor Mbiziwo-Tiapo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-4e4cf62b37da5ff45c904a3acf242ab29ed5881d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mbd@fb.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=nums@google.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox