public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot for Michael S. Tsirkin" <mst@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
	torvalds@linux-foundation.org, mst@redhat.com,
	mtosatti@redhat.com, tglx@linutronix.de, avi@redhat.com
Subject: [tip:x86/apic] x86/apic: Use symbolic APIC_EOI_ACK
Date: Fri, 18 May 2012 03:45:33 -0700	[thread overview]
Message-ID: <tip-4ebcc243901c48ee3baba6bdf179c7315fa8806f@git.kernel.org> (raw)
In-Reply-To: <ecbe4c79d69c172378e47e5a587ff5cd10293c9f.1337184153.git.mst@redhat.com>

Commit-ID:  4ebcc243901c48ee3baba6bdf179c7315fa8806f
Gitweb:     http://git.kernel.org/tip/4ebcc243901c48ee3baba6bdf179c7315fa8806f
Author:     Michael S. Tsirkin <mst@redhat.com>
AuthorDate: Wed, 16 May 2012 19:03:44 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 18 May 2012 09:46:08 +0200

x86/apic: Use symbolic APIC_EOI_ACK

Use the symbol instead of hard-coded numbers,
now that the reason for the value is documented
where the constant is defined we don't need to
duplicate this explanation in code.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Cc: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: gleb@redhat.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/ecbe4c79d69c172378e47e5a587ff5cd10293c9f.1337184153.git.mst@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/include/asm/apic.h |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
index d854101..a09e9ab 100644
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -463,9 +463,7 @@ static inline void ack_APIC_irq(void)
 	 * ack_APIC_irq() actually gets compiled as a single instruction
 	 * ... yummie.
 	 */
-
-	/* Docs say use 0 for future compatibility */
-	apic_write(APIC_EOI, 0);
+	apic_write(APIC_EOI, APIC_EOI_ACK);
 }
 
 static inline unsigned default_get_apic_id(unsigned long x)

  reply	other threads:[~2012-05-18 10:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16 16:03 [PATCHv5 0/4] apic: core part for eoi optimization support Michael S. Tsirkin
2012-05-16 16:03 ` [PATCHv5 1/4] apic: fix typo EIO_ACK -> EOI_ACK and document Michael S. Tsirkin
2012-05-18 10:44   ` [tip:x86/apic] x86/apic: Fix typo EIO_ACK -> EOI_ACK and document it tip-bot for Michael S. Tsirkin
2012-05-16 16:03 ` [PATCHv5 2/4] apic: use symbolic APIC_EOI_ACK Michael S. Tsirkin
2012-05-18 10:45   ` tip-bot for Michael S. Tsirkin [this message]
2012-05-16 16:03 ` [PATCHv5 3/4] x86: add apic->eoi_write callback Michael S. Tsirkin
2012-05-18 10:46   ` [tip:x86/apic] x86/apic: Add apic->eoi_write() callback tip-bot for Michael S. Tsirkin
2012-05-16 16:03 ` [PATCHv5 4/4] x86: eoi micro-optimization Michael S. Tsirkin
2012-05-18 10:47   ` [tip:x86/apic] x86/apic: Implement EIO micro-optimization tip-bot for Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-4ebcc243901c48ee3baba6bdf179c7315fa8806f@git.kernel.org \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox