From: tip-bot for Julia Lawall <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, hpa@zytor.com, Julia.Lawall@lip6.fr,
mingo@kernel.org, linux-kernel@vger.kernel.org,
jason@lakedaemon.net, marc.zyngier@arm.com
Subject: [tip:irq/urgent] irqchip/gic/realview: Drop unnecessary static
Date: Tue, 18 Jul 2017 13:06:56 -0700 [thread overview]
Message-ID: <tip-512f9e790897e84d5b802436768508ee4628fc16@git.kernel.org> (raw)
In-Reply-To: <1500149266-32357-6-git-send-email-Julia.Lawall@lip6.fr>
Commit-ID: 512f9e790897e84d5b802436768508ee4628fc16
Gitweb: http://git.kernel.org/tip/512f9e790897e84d5b802436768508ee4628fc16
Author: Julia Lawall <Julia.Lawall@lip6.fr>
AuthorDate: Sat, 15 Jul 2017 22:07:40 +0200
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 18 Jul 2017 21:59:22 +0200
irqchip/gic/realview: Drop unnecessary static
Drop static on a local variable, when the variable is initialized before
any possible use. Thus, the static has no benefit.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>
@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
T x@p;
... when != x
when strict
?x = e;
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: kernel-janitors@vger.kernel.org
Cc: keescook@chromium.org
Cc: Jason Cooper <jason@lakedaemon.net>
Link: http://lkml.kernel.org/r/1500149266-32357-6-git-send-email-Julia.Lawall@lip6.fr
---
drivers/irqchip/irq-gic-realview.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c
index 54c2964..18d58d2 100644
--- a/drivers/irqchip/irq-gic-realview.c
+++ b/drivers/irqchip/irq-gic-realview.c
@@ -43,7 +43,7 @@ static const struct of_device_id syscon_pldset_of_match[] = {
static int __init
realview_gic_of_init(struct device_node *node, struct device_node *parent)
{
- static struct regmap *map;
+ struct regmap *map;
struct device_node *np;
const struct of_device_id *gic_id;
u32 pld1_ctrl;
next prev parent reply other threads:[~2017-07-18 20:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 20:07 [PATCH 00/11] Drop unnecessary static Julia Lawall
2017-07-15 20:07 ` [PATCH 01/11] clk: mmp: " Julia Lawall
2017-07-18 1:31 ` Stephen Boyd
2017-07-15 20:07 ` [PATCH 02/11] clk: moxart: " Julia Lawall
2017-07-18 1:31 ` Stephen Boyd
2017-07-15 20:07 ` [PATCH 03/11] mtd: physmap_of: " Julia Lawall
2017-07-17 19:58 ` Boris Brezillon
2017-08-17 12:58 ` Boris Brezillon
2017-07-15 20:07 ` [PATCH 04/11] fbdev: da8xx-fb: " Julia Lawall
2017-08-01 13:09 ` Bartlomiej Zolnierkiewicz
2017-07-15 20:07 ` [PATCH 05/11] irqchip/gic/realview: " Julia Lawall
2017-07-18 20:06 ` tip-bot for Julia Lawall [this message]
2017-07-15 20:07 ` [PATCH 06/11] irqchip: mips-cpu: " Julia Lawall
2017-07-15 20:52 ` Mark D Rustad
2017-07-15 20:59 ` Julia Lawall
2017-07-16 6:04 ` Mark D Rustad
2017-07-18 20:07 ` [tip:irq/urgent] irqchip/mips-cpu: " tip-bot for Julia Lawall
2017-07-15 20:07 ` [PATCH 07/11] mfd: " Julia Lawall
2017-07-15 20:49 ` Mark D Rustad
2017-07-15 20:56 ` Julia Lawall
2017-07-24 19:20 ` Pavel Machek
2017-07-24 22:27 ` Kees Cook
2017-07-25 8:00 ` Lee Jones
2017-07-15 20:07 ` [PATCH 08/11] ata: " Julia Lawall
2017-08-02 8:23 ` Linus Walleij
2017-08-02 15:12 ` Tejun Heo
2017-07-15 20:07 ` [PATCH 09/11] iio: orientation: hid-sensor-rotation: " Julia Lawall
2017-07-17 20:45 ` Jonathan Cameron
2017-07-15 20:07 ` [PATCH 10/11] irqchip: digicolor: " Julia Lawall
2017-07-16 4:49 ` Baruch Siach
2017-07-18 20:07 ` [tip:irq/urgent] irqchip/digicolor: " tip-bot for Julia Lawall
2017-07-15 20:07 ` [PATCH 11/11] mfd: max8925-i2c: " Julia Lawall
2017-07-18 7:23 ` Lee Jones
2017-07-15 20:37 ` [PATCH 00/11] " Joe Perches
2017-07-15 21:00 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-512f9e790897e84d5b802436768508ee4628fc16@git.kernel.org \
--to=tipbot@zytor.com \
--cc=Julia.Lawall@lip6.fr \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox