From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755336AbbIMLKR (ORCPT ); Sun, 13 Sep 2015 07:10:17 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43842 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346AbbIMLKN (ORCPT ); Sun, 13 Sep 2015 07:10:13 -0400 Date: Sun, 13 Sep 2015 04:09:32 -0700 From: tip-bot for Kirill Tkhai Message-ID: Cc: tglx@linutronix.de, mingo@kernel.org, ktkhai@odin.com, peterz@infradead.org, torvalds@linux-foundation.org, acme@redhat.com, linux-kernel@vger.kernel.org, jolsa@redhat.com, vincent.weaver@maine.edu, hpa@zytor.com, eranian@google.com Reply-To: jolsa@redhat.com, vincent.weaver@maine.edu, hpa@zytor.com, eranian@google.com, tglx@linutronix.de, mingo@kernel.org, torvalds@linux-foundation.org, peterz@infradead.org, ktkhai@odin.com, linux-kernel@vger.kernel.org, acme@redhat.com In-Reply-To: <55E444C8.3020402@odin.com> References: <55E444C8.3020402@odin.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf/core: Delete PF_EXITING checks from perf_cgroup_exit() callback Git-Commit-ID: 516792e67c39d31701641ab355acdb9cbfec0643 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 516792e67c39d31701641ab355acdb9cbfec0643 Gitweb: http://git.kernel.org/tip/516792e67c39d31701641ab355acdb9cbfec0643 Author: Kirill Tkhai AuthorDate: Mon, 31 Aug 2015 15:12:56 +0300 Committer: Ingo Molnar CommitDate: Sun, 13 Sep 2015 11:27:23 +0200 perf/core: Delete PF_EXITING checks from perf_cgroup_exit() callback cgroup_exit() is not called from copy_process() after commit: e8604cb43690 ("cgroup: fix spurious lockdep warning in cgroup_exit()") from do_exit(). So this check is useless and the comment is obsolete. Signed-off-by: Kirill Tkhai Signed-off-by: Peter Zijlstra (Intel) Cc: Arnaldo Carvalho de Melo Cc: Jiri Olsa Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Thomas Gleixner Cc: Vince Weaver Link: http://lkml.kernel.org/r/55E444C8.3020402@odin.com Signed-off-by: Ingo Molnar --- kernel/events/core.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index f548f69..76e64be 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9297,14 +9297,6 @@ static void perf_cgroup_exit(struct cgroup_subsys_state *css, struct cgroup_subsys_state *old_css, struct task_struct *task) { - /* - * cgroup_exit() is called in the copy_process() failure path. - * Ignore this case since the task hasn't ran yet, this avoids - * trying to poke a half freed task state from generic code. - */ - if (!(task->flags & PF_EXITING)) - return; - task_function_call(task, __perf_cgroup_move, task); }