From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934321AbcKOKuW (ORCPT ); Tue, 15 Nov 2016 05:50:22 -0500 Received: from terminus.zytor.com ([198.137.202.10]:51304 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754177AbcKOKuQ (ORCPT ); Tue, 15 Nov 2016 05:50:16 -0500 Date: Tue, 15 Nov 2016 02:49:42 -0800 From: tip-bot for Paul Gortmaker Message-ID: Cc: paul.gortmaker@windriver.com, tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org, peterz@infradead.org, torvalds@linux-foundation.org, hpa@zytor.com, mingo@kernel.org Reply-To: hpa@zytor.com, mingo@kernel.org, tglx@linutronix.de, paul.gortmaker@windriver.com, peterz@infradead.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@redhat.com In-Reply-To: <20161114190443.10873-1-paul.gortmaker@windriver.com> References: <20161114190443.10873-1-paul.gortmaker@windriver.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/headers] x86/percpu: Remove unnecessary include of module.h, add asm/desc.h Git-Commit-ID: 523d0fb4f05dcefed59c6325acb54adc34ee4c2d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 523d0fb4f05dcefed59c6325acb54adc34ee4c2d Gitweb: http://git.kernel.org/tip/523d0fb4f05dcefed59c6325acb54adc34ee4c2d Author: Paul Gortmaker AuthorDate: Mon, 14 Nov 2016 14:04:43 -0500 Committer: Ingo Molnar CommitDate: Tue, 15 Nov 2016 07:26:37 +0100 x86/percpu: Remove unnecessary include of module.h, add asm/desc.h This was originally a part of commit 186f43608a5c: ("x86/kernel: Audit and remove any unnecessary uses of module.h") ...but without the asm/desc.h addition. As such, Ingo reported a build failure on i386 allnoconfig with SMP=y during his pre-merge testing. For expediency the chunk was just dropped at that time. The failure was as follows: arch/x86/kernel/setup_percpu.c: In function ‘setup_percpu_segment’: arch/x86/kernel/setup_percpu.c:159:2: error: implicit declaration of function ‘pack_descriptor’ [-Werror=implicit-function-declaration] arch/x86/kernel/setup_percpu.c:162:2: error: implicit declaration of function ‘write_gdt_entry’ [-Werror=implicit-function-declaration] arch/x86/kernel/setup_percpu.c:162:18: error: implicit declaration of function ‘get_cpu_gdt_table’ [-Werror=implicit-function-declaration] As pack_descriptor(), write_gdt_entry() and get_cpu_gdt_table() all live in the file arch/x86/include/asm/desc.h -- calling that header out explicitly should fix things. Reported-by: Ingo Molnar Signed-off-by: Paul Gortmaker Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20161114190443.10873-1-paul.gortmaker@windriver.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/setup_percpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/setup_percpu.c b/arch/x86/kernel/setup_percpu.c index 2bbd27f..9820d6d 100644 --- a/arch/x86/kernel/setup_percpu.c +++ b/arch/x86/kernel/setup_percpu.c @@ -1,7 +1,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include -#include +#include #include #include #include @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include