From: tip-bot for Sergei Trofimovich <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, mingo@kernel.org, acme@redhat.com,
adrian.hunter@intel.com, jolsa@kernel.org, hpa@zytor.com,
siarheit@google.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl
Subject: [tip:perf/core] perf tools: Fix makefile generation under dash
Date: Tue, 21 Jul 2015 02:35:54 -0700 [thread overview]
Message-ID: <tip-52c0a18b9010fb19d10889e8a00aa784197d357c@git.kernel.org> (raw)
In-Reply-To: <1437298205-29305-1-git-send-email-siarheit@google.com>
Commit-ID: 52c0a18b9010fb19d10889e8a00aa784197d357c
Gitweb: http://git.kernel.org/tip/52c0a18b9010fb19d10889e8a00aa784197d357c
Author: Sergei Trofimovich <siarheit@google.com>
AuthorDate: Sun, 19 Jul 2015 10:30:05 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 20 Jul 2015 17:49:50 -0300
perf tools: Fix makefile generation under dash
Under dash 'echo -n' yields '-n' to stdout. Use printf "" instead.
Signed-off-by: Sergei Trofimovich <siarheit@google.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1437298205-29305-1-git-send-email-siarheit@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/config/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
index a9b93d1..8768f84 100644
--- a/tools/perf/config/Makefile
+++ b/tools/perf/config/Makefile
@@ -11,7 +11,7 @@ ifneq ($(obj-perf),)
obj-perf := $(abspath $(obj-perf))/
endif
-$(shell echo -n > $(OUTPUT).config-detected)
+$(shell printf "" > $(OUTPUT).config-detected)
detected = $(shell echo "$(1)=y" >> $(OUTPUT).config-detected)
detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
prev parent reply other threads:[~2015-07-21 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 9:30 [PATCH] perf: fix makefile generation under dash Sergei Trofimovich
2015-07-19 19:17 ` Jiri Olsa
2015-07-20 7:44 ` Ingo Molnar
2015-07-20 18:44 ` Arnaldo Carvalho de Melo
2015-07-21 9:35 ` tip-bot for Sergei Trofimovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-52c0a18b9010fb19d10889e8a00aa784197d357c@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=siarheit@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).