From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbcF0NBg (ORCPT ); Mon, 27 Jun 2016 09:01:36 -0400 Received: from terminus.zytor.com ([198.137.202.10]:41908 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbcF0NBf (ORCPT ); Mon, 27 Jun 2016 09:01:35 -0400 Date: Mon, 27 Jun 2016 06:00:49 -0700 From: "tip-bot for Compostella, Jeremy" Message-ID: Cc: elliott@hpe.com, ard.biesheuvel@linaro.org, tglx@linutronix.de, matt@codeblueprint.co.uk, hpa@zytor.com, jeremy.compostella@intel.com, peterz@infradead.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, arnd@arndb.de Reply-To: mingo@kernel.org, arnd@arndb.de, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, peterz@infradead.org, hpa@zytor.com, jeremy.compostella@intel.com, matt@codeblueprint.co.uk, ard.biesheuvel@linaro.org, tglx@linutronix.de, elliott@hpe.com In-Reply-To: <1466839230-12781-2-git-send-email-matt@codeblueprint.co.uk> References: <1466839230-12781-2-git-send-email-matt@codeblueprint.co.uk> To: linux-tip-commits@vger.kernel.org Subject: [tip:efi/core] efibc: Report more information in the error messages Git-Commit-ID: 5356c32742bd51c8c57065d2389a2c4bc036adcd X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 5356c32742bd51c8c57065d2389a2c4bc036adcd Gitweb: http://git.kernel.org/tip/5356c32742bd51c8c57065d2389a2c4bc036adcd Author: Compostella, Jeremy AuthorDate: Sat, 25 Jun 2016 08:20:24 +0100 Committer: Ingo Molnar CommitDate: Mon, 27 Jun 2016 13:06:54 +0200 efibc: Report more information in the error messages Report the name of the EFI variable if the value size is too large, or if efibc_set_variable() fails to allocate the 'struct efivar_entry' object. If efibc_set_variable() fails because the 'size' value is too large, it also reports this value in the error message. Reported-by: Robert Elliott Signed-off-by: Jeremy Compostella Signed-off-by: Matt Fleming Cc: Ard Biesheuvel Cc: Arnd Bergmann Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/1466839230-12781-2-git-send-email-matt@codeblueprint.co.uk [ Minor readability edits. ] Signed-off-by: Ingo Molnar --- drivers/firmware/efi/efibc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/efibc.c b/drivers/firmware/efi/efibc.c index 8dd0c70..503bbe2 100644 --- a/drivers/firmware/efi/efibc.c +++ b/drivers/firmware/efi/efibc.c @@ -37,13 +37,13 @@ static int efibc_set_variable(const char *name, const char *value) size_t size = (strlen(value) + 1) * sizeof(efi_char16_t); if (size > sizeof(entry->var.Data)) { - pr_err("value is too large"); + pr_err("value is too large (%zu bytes) for '%s' EFI variable\n", size, name); return -EINVAL; } entry = kmalloc(sizeof(*entry), GFP_KERNEL); if (!entry) { - pr_err("failed to allocate efivar entry"); + pr_err("failed to allocate efivar entry for '%s' EFI variable\n", name); return -ENOMEM; }