linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Nicolas Pitre <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: hpa@zytor.com, richardcochran@gmail.com,
	nicolas.pitre@linaro.org, mingo@kernel.org, pebolle@tiscali.nl,
	linux-kernel@vger.kernel.org, nico@linaro.org,
	john.stultz@linaro.org, josh@joshtriplett.org,
	tglx@linutronix.de, ecree@solarflare.com, mmarek@suse.com
Subject: [tip:timers/core] posix_cpu_timers: Move the add_device_randomness() call to a proper place
Date: Wed, 16 Nov 2016 00:33:06 -0800	[thread overview]
Message-ID: <tip-53d3eaa31508222e445b489f3c3ac4c63542a4ef@git.kernel.org> (raw)
In-Reply-To: <1478841010-28605-6-git-send-email-nicolas.pitre@linaro.org>

Commit-ID:  53d3eaa31508222e445b489f3c3ac4c63542a4ef
Gitweb:     http://git.kernel.org/tip/53d3eaa31508222e445b489f3c3ac4c63542a4ef
Author:     Nicolas Pitre <nicolas.pitre@linaro.org>
AuthorDate: Fri, 11 Nov 2016 00:10:09 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 16 Nov 2016 09:26:34 +0100

posix_cpu_timers: Move the add_device_randomness() call to a proper place

There is no logical relation between add_device_randomness() and
posix_cpu_timers_exit(). Let's move the former to where the later
is called. This way, when posix-cpu-timers.c is compiled out, there
is no need to worry about not losing a call to add_device_randomness().

Signed-off-by: Nicolas Pitre <nico@linaro.org>
Acked-by: John Stultz <john.stultz@linaro.org>
Cc: Paul Bolle <pebolle@tiscali.nl>
Cc: linux-kbuild@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Michal Marek <mmarek@suse.com>
Cc: Edward Cree <ecree@solarflare.com>
Link: http://lkml.kernel.org/r/1478841010-28605-6-git-send-email-nicolas.pitre@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 kernel/exit.c                  | 4 ++++
 kernel/time/posix-cpu-timers.c | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index 9d68c45..d16bcdd 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -54,6 +54,7 @@
 #include <linux/writeback.h>
 #include <linux/shm.h>
 #include <linux/kcov.h>
+#include <linux/random.h>
 
 #include <asm/uaccess.h>
 #include <asm/unistd.h>
@@ -116,6 +117,9 @@ static void __exit_signal(struct task_struct *tsk)
 			sig->curr_target = next_thread(tsk);
 	}
 
+	add_device_randomness((const void*) &tsk->se.sum_exec_runtime,
+			      sizeof(unsigned long long));
+
 	/*
 	 * Accumulate here the counters for all threads as they die. We could
 	 * skip the group leader because it is the last user of signal_struct,
diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
index 39008d7..e582f20 100644
--- a/kernel/time/posix-cpu-timers.c
+++ b/kernel/time/posix-cpu-timers.c
@@ -9,7 +9,6 @@
 #include <asm/uaccess.h>
 #include <linux/kernel_stat.h>
 #include <trace/events/timer.h>
-#include <linux/random.h>
 #include <linux/tick.h>
 #include <linux/workqueue.h>
 
@@ -447,10 +446,7 @@ static void cleanup_timers(struct list_head *head)
  */
 void posix_cpu_timers_exit(struct task_struct *tsk)
 {
-	add_device_randomness((const void*) &tsk->se.sum_exec_runtime,
-						sizeof(unsigned long long));
 	cleanup_timers(tsk->cpu_timers);
-
 }
 void posix_cpu_timers_exit_group(struct task_struct *tsk)
 {

  reply	other threads:[~2016-11-16  8:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11  5:10 [PATCH v4 0/6] make POSIX timers optional with some Kconfig help Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 1/6] kconfig: introduce the "imply" keyword Nicolas Pitre
2016-11-16  8:30   ` [tip:timers/core] Kconfig: Introduce " tip-bot for Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 2/6] kconfig: regenerate *.c_shipped files after previous changes Nicolas Pitre
2016-11-16  8:31   ` [tip:timers/core] Kconfig: Regenerate " tip-bot for Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 3/6] ptp_clock: allow for it to be optional Nicolas Pitre
2016-11-16  8:32   ` [tip:timers/core] ptp_clock: Allow " tip-bot for Nicolas Pitre
2016-11-17 16:44     ` Arnd Bergmann
2016-11-18  0:48       ` Nicolas Pitre
2016-11-18  9:15         ` Arnd Bergmann
2016-11-11  5:10 ` [PATCH v4 4/6] timer: move sys_alarm from timer.c to itimer.c Nicolas Pitre
2016-11-16  8:32   ` [tip:timers/core] timer: Move " tip-bot for Nicolas Pitre
2016-11-11  5:10 ` [PATCH v4 5/6] posix_cpu_timers_exit: wrong place to collect entropy Nicolas Pitre
2016-11-16  8:33   ` tip-bot for Nicolas Pitre [this message]
2016-11-11  5:10 ` [PATCH v4 6/6] posix-timers: make it configurable Nicolas Pitre
2016-11-16  0:48   ` John Stultz
2016-11-16  8:33   ` [tip:timers/core] posix-timers: Make them configurable tip-bot for Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-53d3eaa31508222e445b489f3c3ac4c63542a4ef@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=ecree@solarflare.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mmarek@suse.com \
    --cc=nico@linaro.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=pebolle@tiscali.nl \
    --cc=richardcochran@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).