From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932854AbcBWJKo (ORCPT ); Tue, 23 Feb 2016 04:10:44 -0500 Received: from terminus.zytor.com ([198.137.202.10]:58332 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757611AbcBWJKm (ORCPT ); Tue, 23 Feb 2016 04:10:42 -0500 Date: Tue, 23 Feb 2016 01:01:25 -0800 From: =?UTF-8?B?dGlwLWJvdCBmb3IgSm9zaCBQb2ltYm9ldWYgPHRpcGJvdEB6eXRvci5jb20+?=@zytor.com Message-ID: Cc: torvalds@linux-foundation.org, chris.j.arges@canonical.com, linux-kernel@vger.kernel.org, namhyung@gmail.com, tglx@linutronix.de, bp@suse.de, mmarek@suse.cz, dvlasenk@redhat.com, jslaby@suse.cz, luto@kernel.org, palves@redhat.com, hpa@zytor.com, matt@codeblueprint.co.uk, akpm@linux-foundation.org, peterz@infradead.org, acme@kernel.org, bp@alien8.de, mingo@kernel.org, luto@amacapital.net, bernd@petrovitsch.priv.at, brgerst@gmail.com, jpoimboe@redhat.com Reply-To: akpm@linux-foundation.org, matt@codeblueprint.co.uk, luto@kernel.org, hpa@zytor.com, palves@redhat.com, peterz@infradead.org, jslaby@suse.cz, brgerst@gmail.com, bernd@petrovitsch.priv.at, jpoimboe@redhat.com, luto@amacapital.net, mingo@kernel.org, bp@alien8.de, acme@kernel.org, namhyung@gmail.com, tglx@linutronix.de, torvalds@linux-foundation.org, chris.j.arges@canonical.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, mmarek@suse.cz, bp@suse.de In-Reply-To: <2294b6fad60eea4cc862eddc8e98a1324e6eeeca.1453405861.git.jpoimboe@redhat.com> References: <2294b6fad60eea4cc862eddc8e98a1324e6eeeca.1453405861.git.jpoimboe@redhat.com> To: =?UTF-8?B?bGludXgtdGlwLWNvbW1pdHNAdmdlci5rZXJuZWwub3Jn?=@zytor.com Subject: =?UTF-8?B?W3RpcDp4ODYvZGVidWddIHg4Ni9hc20vZWZpOiBDcmVhdGUgYSBzdGFjayBmcmE=?= =?UTF-8?B?bWUgaW4gZWZpX2NhbGwoKQ==?= Git-Commit-ID: =?UTF-8?B?NTRiYjU1ZmEyOTIyZGE3NmQzODU2YjQ2NWMxYjIyZjI0MmQ0MmRhYQ==?= X-Mailer: =?UTF-8?B?dGlwLWdpdC1sb2ctZGFlbW9u?= Robot-ID: =?UTF-8?B?PHRpcC1ib3QuZ2l0Lmtlcm5lbC5vcmc+?= Robot-Unsubscribe: =?UTF-8?B?Q29udGFjdCA8bWFpbHRvOmhwYUBrZXJuZWwub3JnPiB0byBnZXQgYmxhY2tsaXM=?= =?UTF-8?B?dGVkIGZyb20gdGhlc2UgZW1haWxz?= MIME-Version: =?UTF-8?B?MS4w?= Content-Transfer-Encoding: =?UTF-8?B?OGJpdA==?= Content-Type: =?UTF-8?B?dGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOA==?= Content-Disposition: =?UTF-8?B?aW5saW5l?= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 54bb55fa2922da76d3856b465c1b22f242d42daa Gitweb: http://git.kernel.org/tip/54bb55fa2922da76d3856b465c1b22f242d42daa Author: Josh Poimboeuf AuthorDate: Thu, 21 Jan 2016 16:49:23 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:03:58 +0100 x86/asm/efi: Create a stack frame in efi_call() efi_call() is a callable non-leaf function which doesn't honor CONFIG_FRAME_POINTER, which can result in bad stack traces. Create a stack frame for it when CONFIG_FRAME_POINTER is enabled. Signed-off-by: Josh Poimboeuf Reviewed-by: Matt Fleming Reviewed-by: Borislav Petkov Cc: Andrew Morton Cc: Andy Lutomirski Cc: Andy Lutomirski Cc: Arnaldo Carvalho de Melo Cc: Bernd Petrovitsch Cc: Borislav Petkov Cc: Brian Gerst Cc: Chris J Arges Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Jiri Slaby Cc: Linus Torvalds Cc: Michal Marek Cc: Namhyung Kim Cc: Pedro Alves Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: live-patching@vger.kernel.org Link: http://lkml.kernel.org/r/2294b6fad60eea4cc862eddc8e98a1324e6eeeca.1453405861.git.jpoimboe@redhat.com Signed-off-by: Ingo Molnar --- arch/x86/platform/efi/efi_stub_64.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/platform/efi/efi_stub_64.S b/arch/x86/platform/efi/efi_stub_64.S index 86d0f9e..0df2dcc 100644 --- a/arch/x86/platform/efi/efi_stub_64.S +++ b/arch/x86/platform/efi/efi_stub_64.S @@ -11,6 +11,7 @@ #include #include #include +#include #define SAVE_XMM \ mov %rsp, %rax; \ @@ -74,6 +75,7 @@ .endm ENTRY(efi_call) + FRAME_BEGIN SAVE_XMM mov (%rsp), %rax mov 8(%rax), %rax @@ -88,6 +90,7 @@ ENTRY(efi_call) RESTORE_PGT addq $48, %rsp RESTORE_XMM + FRAME_END ret ENDPROC(efi_call)