linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Chunyu Hu <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: chuhu@redhat.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com
Subject: [tip:x86/urgent] x86/idt: Load idt early in start_secondary
Date: Mon, 27 Nov 2017 23:22:14 -0800	[thread overview]
Message-ID: <tip-55d2d0ad2fb4325f615d1950486fbc5e6fba1769@git.kernel.org> (raw)
In-Reply-To: <1511792499-4073-1-git-send-email-chuhu@redhat.com>

Commit-ID:  55d2d0ad2fb4325f615d1950486fbc5e6fba1769
Gitweb:     https://git.kernel.org/tip/55d2d0ad2fb4325f615d1950486fbc5e6fba1769
Author:     Chunyu Hu <chuhu@redhat.com>
AuthorDate: Mon, 27 Nov 2017 22:21:39 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 28 Nov 2017 08:15:40 +0100

x86/idt: Load idt early in start_secondary

On a secondary, idt is first loaded in cpu_init() with load_current_idt(),
i.e. no exceptions can be handled before that point.

The conversion of WARN() to use UD requires the IDT being loaded earlier as
any warning between start_secondary() and load_curren_idt() in cpu_init()
will result in an unhandled @UD exception and therefore fail the bringup of
the CPU.

Install the IDT handlers right in start_secondary() before calling cpu_init().

[ tglx: Massaged changelog ]

Fixes: 9a93848fe787 ("x86/debug: Implement __WARN() using UD0")
Signed-off-by: Chunyu Hu <chuhu@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Cc: peterz@infradead.org
Cc: bp@alien8.de
Cc: rostedt@goodmis.org
Cc: luto@kernel.org
Link: https://lkml.kernel.org/r/1511792499-4073-1-git-send-email-chuhu@redhat.com
---
 arch/x86/kernel/smpboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 3d01df7..05a97d5 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -237,7 +237,7 @@ static void notrace start_secondary(void *unused)
 	load_cr3(swapper_pg_dir);
 	__flush_tlb_all();
 #endif
-
+	load_current_idt();
 	cpu_init();
 	x86_cpuinit.early_percpu_clock_init();
 	preempt_disable();

      parent reply	other threads:[~2017-11-28  7:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-27 14:21 [PATCH] x86/idt: load idt early in start_secondary Chunyu Hu
2017-11-27 23:35 ` [tip:x86/urgent] x86/idt: Load " tip-bot for Chunyu Hu
2017-11-28  3:41 ` [PATCH] x86/idt: load " Andy Lutomirski
2017-11-28  4:57   ` Chunyu Hu
2017-11-28  5:28     ` Andy Lutomirski
2017-11-28  7:17       ` Thomas Gleixner
2017-11-28 14:56     ` Steven Rostedt
2017-11-28  7:22 ` tip-bot for Chunyu Hu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-55d2d0ad2fb4325f615d1950486fbc5e6fba1769@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=chuhu@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).