From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751830AbdK1HX0 (ORCPT ); Tue, 28 Nov 2017 02:23:26 -0500 Received: from terminus.zytor.com ([65.50.211.136]:49481 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbdK1HXY (ORCPT ); Tue, 28 Nov 2017 02:23:24 -0500 Date: Mon, 27 Nov 2017 23:22:14 -0800 From: tip-bot for Chunyu Hu Message-ID: Cc: chuhu@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com Reply-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, chuhu@redhat.com In-Reply-To: <1511792499-4073-1-git-send-email-chuhu@redhat.com> References: <1511792499-4073-1-git-send-email-chuhu@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/idt: Load idt early in start_secondary Git-Commit-ID: 55d2d0ad2fb4325f615d1950486fbc5e6fba1769 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 55d2d0ad2fb4325f615d1950486fbc5e6fba1769 Gitweb: https://git.kernel.org/tip/55d2d0ad2fb4325f615d1950486fbc5e6fba1769 Author: Chunyu Hu AuthorDate: Mon, 27 Nov 2017 22:21:39 +0800 Committer: Thomas Gleixner CommitDate: Tue, 28 Nov 2017 08:15:40 +0100 x86/idt: Load idt early in start_secondary On a secondary, idt is first loaded in cpu_init() with load_current_idt(), i.e. no exceptions can be handled before that point. The conversion of WARN() to use UD requires the IDT being loaded earlier as any warning between start_secondary() and load_curren_idt() in cpu_init() will result in an unhandled @UD exception and therefore fail the bringup of the CPU. Install the IDT handlers right in start_secondary() before calling cpu_init(). [ tglx: Massaged changelog ] Fixes: 9a93848fe787 ("x86/debug: Implement __WARN() using UD0") Signed-off-by: Chunyu Hu Signed-off-by: Thomas Gleixner Cc: stable@vger.kernel.org Cc: peterz@infradead.org Cc: bp@alien8.de Cc: rostedt@goodmis.org Cc: luto@kernel.org Link: https://lkml.kernel.org/r/1511792499-4073-1-git-send-email-chuhu@redhat.com --- arch/x86/kernel/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 3d01df7..05a97d5 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -237,7 +237,7 @@ static void notrace start_secondary(void *unused) load_cr3(swapper_pg_dir); __flush_tlb_all(); #endif - + load_current_idt(); cpu_init(); x86_cpuinit.early_percpu_clock_init(); preempt_disable();