From: tip-bot for Jin Dongming <jin.dongming@np.css.fujitsu.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
jin.dongming@np.css.fujitsu.com, seto.hidetoshi@jp.fujitsu.com,
fenghua.yu@intel.com, khali@linux-fr.org, tglx@linutronix.de,
mingo@elte.hu, len.brown@intel.com
Subject: [tip:x86/debug] therm_throt.c: Trivial printk message fix for a unsuitable abbreviation of 'thermal'
Date: Sun, 5 Sep 2010 18:30:48 GMT [thread overview]
Message-ID: <tip-592091c0e21655bfbdf68741dd5a920c2ac2bbe6@git.kernel.org> (raw)
In-Reply-To: <4C7C492D.5020704@np.css.fujitsu.com>
Commit-ID: 592091c0e21655bfbdf68741dd5a920c2ac2bbe6
Gitweb: http://git.kernel.org/tip/592091c0e21655bfbdf68741dd5a920c2ac2bbe6
Author: Jin Dongming <jin.dongming@np.css.fujitsu.com>
AuthorDate: Tue, 31 Aug 2010 09:13:33 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 5 Sep 2010 20:26:50 +0200
therm_throt.c: Trivial printk message fix for a unsuitable abbreviation of 'thermal'
In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.
I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.
I think this patch will fix it.
Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Reviewed-by: Jean Delvare <khali@linux-fr.org>
Cc: Brown Len <len.brown@intel.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
LKML-Reference: <4C7C492D.5020704@np.css.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index c2a8b26..1d0f743 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -348,7 +348,7 @@ static void intel_thermal_interrupt(void)
static void unexpected_thermal_interrupt(void)
{
- printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+ printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
smp_processor_id());
add_taint(TAINT_MACHINE_CHECK);
}
prev parent reply other threads:[~2010-09-05 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 7:52 [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal Jin Dongming
2010-08-30 7:57 ` [lm-sensors] " Jean Delvare
2010-08-31 0:13 ` [Patch-next -v2]therm_throt.c: " Jin Dongming
2010-08-31 6:56 ` Jean Delvare
2010-08-31 17:30 ` Fenghua Yu
2010-09-05 13:06 ` [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal' tip-bot for Jin Dongming
2010-09-05 16:59 ` Jean Delvare
2010-09-05 18:30 ` tip-bot for Jin Dongming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-592091c0e21655bfbdf68741dd5a920c2ac2bbe6@git.kernel.org \
--to=jin.dongming@np.css.fujitsu.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=khali@linux-fr.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox