public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Alexander Shishkin <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: paulus@samba.org, alexander.shishkin@linux.intel.com,
	torvalds@linux-foundation.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, peterz@infradead.org,
	hpa@zytor.com, tglx@linutronix.de
Subject: [tip:perf/core] perf/x86/intel/pt: Document pt_buffer_reset_offsets()
Date: Wed, 27 May 2015 03:08:18 -0700	[thread overview]
Message-ID: <tip-5b1dbd17c0dee679b154ce47f534677b7e0f7ad6@git.kernel.org> (raw)
In-Reply-To: <1429622177-22843-5-git-send-email-alexander.shishkin@linux.intel.com>

Commit-ID:  5b1dbd17c0dee679b154ce47f534677b7e0f7ad6
Gitweb:     http://git.kernel.org/tip/5b1dbd17c0dee679b154ce47f534677b7e0f7ad6
Author:     Alexander Shishkin <alexander.shishkin@linux.intel.com>
AuthorDate: Tue, 21 Apr 2015 16:16:16 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 27 May 2015 09:17:47 +0200

perf/x86/intel/pt: Document pt_buffer_reset_offsets()

Currently, the description of pt_buffer_reset_offsets() lacks information
about its calling constraints and ordering with regards to other buffer
management functions.

Add a clarification about when this function has to be called.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: acme@infradead.org
Cc: adrian.hunter@intel.com
Cc: hpa@zytor.com
Link: http://lkml.kernel.org/r/1429622177-22843-5-git-send-email-alexander.shishkin@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/cpu/perf_event_intel_pt.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
index b2746ea..40ba5e4 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
@@ -705,7 +705,14 @@ static void pt_buffer_setup_topa_index(struct pt_buffer *buf)
  * @head:	Write pointer (aux_head) from AUX buffer.
  *
  * Find the ToPA table and entry corresponding to given @head and set buffer's
- * "current" pointers accordingly.
+ * "current" pointers accordingly. This is done after we have obtained the
+ * current aux_head position from a successful call to perf_aux_output_begin()
+ * to make sure the hardware is writing to the right place.
+ *
+ * This function modifies buf::{cur,cur_idx,output_off} that will be programmed
+ * into PT msrs when the tracing is enabled and buf::head and buf::data_size,
+ * which are used to determine INT and STOP markers' locations by a subsequent
+ * call to pt_buffer_reset_markers().
  */
 static void pt_buffer_reset_offsets(struct pt_buffer *buf, unsigned long head)
 {

  reply	other threads:[~2015-05-27 10:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 13:16 [PATCH 0/5] perf/x86/intel/pt: Driver fixes and cleanups Alexander Shishkin
2015-04-21 13:16 ` [PATCH 1/5] perf/x86/intel/pt: Kill an unused variable Alexander Shishkin
2015-05-27 10:07   ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-04-21 13:16 ` [PATCH 2/5] perf/x86/intel/pt: Untangle pt_buffer_reset_markers() Alexander Shishkin
2015-04-21 13:16 ` [PATCH 3/5] perf/x86/intel/pt: Document pt_buffer_reset_markers() Alexander Shishkin
2015-05-27 10:07   ` [tip:perf/core] " tip-bot for Alexander Shishkin
2015-04-21 13:16 ` [PATCH 4/5] perf/x86/intel/pt: Document pt_buffer_reset_offsets() Alexander Shishkin
2015-05-27 10:08   ` tip-bot for Alexander Shishkin [this message]
2015-04-21 13:16 ` [PATCH 5/5] perf/x86/intel/pt: Kill pt_is_running() Alexander Shishkin
2015-05-27 10:08   ` [tip:perf/core] " tip-bot for Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-5b1dbd17c0dee679b154ce47f534677b7e0f7ad6@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox