From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbdEEISW (ORCPT ); Fri, 5 May 2017 04:18:22 -0400 Received: from terminus.zytor.com ([65.50.211.136]:35035 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbdEEISU (ORCPT ); Fri, 5 May 2017 04:18:20 -0400 Date: Fri, 5 May 2017 01:10:40 -0700 From: tip-bot for Daniel Micay Message-ID: Cc: mingo@kernel.org, peterz@infradead.org, keescook@chromium.org, torvalds@linux-foundation.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, arjan@linux.intel.com, hpa@zytor.com, danielmicay@gmail.com, riel@redhat.com Reply-To: hpa@zytor.com, riel@redhat.com, danielmicay@gmail.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, arjan@linux.intel.com, peterz@infradead.org, keescook@chromium.org, torvalds@linux-foundation.org, mingo@kernel.org In-Reply-To: <20170504133209.3053-1-danielmicay@gmail.com> References: <20170504133209.3053-1-danielmicay@gmail.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/urgent] stackprotector: Increase the per-task stack canary's random range from 32 bits to 64 bits on 64-bit platforms Git-Commit-ID: 5ea30e4e58040cfd6434c2f33dc3ea76e2c15b05 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 5ea30e4e58040cfd6434c2f33dc3ea76e2c15b05 Gitweb: http://git.kernel.org/tip/5ea30e4e58040cfd6434c2f33dc3ea76e2c15b05 Author: Daniel Micay AuthorDate: Thu, 4 May 2017 09:32:09 -0400 Committer: Ingo Molnar CommitDate: Fri, 5 May 2017 08:05:13 +0200 stackprotector: Increase the per-task stack canary's random range from 32 bits to 64 bits on 64-bit platforms The stack canary is an 'unsigned long' and should be fully initialized to random data rather than only 32 bits of random data. Signed-off-by: Daniel Micay Acked-by: Arjan van de Ven Acked-by: Rik van Riel Acked-by: Kees Cook Cc: Arjan van Ven Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: kernel-hardening@lists.openwall.com Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/20170504133209.3053-1-danielmicay@gmail.com Signed-off-by: Ingo Molnar --- kernel/fork.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/fork.c b/kernel/fork.c index 3a4343c..d681f8f 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -536,7 +536,7 @@ static struct task_struct *dup_task_struct(struct task_struct *orig, int node) set_task_stack_end_magic(tsk); #ifdef CONFIG_CC_STACKPROTECTOR - tsk->stack_canary = get_random_int(); + tsk->stack_canary = get_random_long(); #endif /*