From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163AbdIEF0M (ORCPT ); Tue, 5 Sep 2017 01:26:12 -0400 Received: from terminus.zytor.com ([65.50.211.136]:55653 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdIEF0G (ORCPT ); Tue, 5 Sep 2017 01:26:06 -0400 Date: Mon, 4 Sep 2017 22:23:56 -0700 From: tip-bot for Arnaldo Carvalho de Melo Message-ID: Cc: wangnan0@huawei.com, hpa@zytor.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, acme@redhat.com, fbl@redhat.com, treeze.taeung@gmail.com, namhyung@kernel.org, adrian.hunter@intel.com, tglx@linutronix.de Reply-To: adrian.hunter@intel.com, tglx@linutronix.de, namhyung@kernel.org, treeze.taeung@gmail.com, acme@redhat.com, fbl@redhat.com, hpa@zytor.com, wangnan0@huawei.com, mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB Git-Commit-ID: eba9fac017617e685d648339e29a1453a30cb065 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: eba9fac017617e685d648339e29a1453a30cb065 Gitweb: http://git.kernel.org/tip/eba9fac017617e685d648339e29a1453a30cb065 Author: Arnaldo Carvalho de Melo AuthorDate: Fri, 1 Sep 2017 14:55:40 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 1 Sep 2017 14:55:40 -0300 perf annotate browser: Help for cycling thru hottest instructions with TAB/shift+TAB The popup help accessed via 'h' wasn't mentioning about TAB and shift-TAB, just about 'H', which goes to the hottest line, while the former two are the hotkeys for actually cycling thru the hottest lines. Reported-by: Flavio Bruno Leitner Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Cc: Taeung Song Cc: Wang Nan Link: http://lkml.kernel.org/n/tip-5ppym6odizfj1ifa4t7neiku@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/ui/browsers/annotate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index ba0aee5..786feca 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c @@ -829,7 +829,8 @@ static int annotate_browser__run(struct annotate_browser *browser, "q/ESC/CTRL+C Exit\n\n" "ENTER Go to target\n" "ESC Exit\n" - "H Cycle thru hottest instructions\n" + "H Go to hottest instruction\n" + "TAB/shift+TAB Cycle thru hottest instructions\n" "j Toggle showing jump to target arrows\n" "J Toggle showing number of jump sources on targets\n" "n Search next string\n"