From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938058AbdAEHyG (ORCPT ); Thu, 5 Jan 2017 02:54:06 -0500 Received: from terminus.zytor.com ([198.137.202.10]:57168 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499AbdAEHx3 (ORCPT ); Thu, 5 Jan 2017 02:53:29 -0500 Date: Wed, 4 Jan 2017 23:52:11 -0800 From: tip-bot for Jiri Olsa Message-ID: Cc: hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, wangnan0@huawei.com, dsahern@gmail.com, jolsa@kernel.org, a.p.zijlstra@chello.nl, namhyung@kernel.org, linux-kernel@vger.kernel.org, acme@redhat.com Reply-To: acme@redhat.com, a.p.zijlstra@chello.nl, namhyung@kernel.org, linux-kernel@vger.kernel.org, wangnan0@huawei.com, mingo@kernel.org, dsahern@gmail.com, jolsa@kernel.org, hpa@zytor.com, tglx@linutronix.de In-Reply-To: <1483431600-19887-4-git-send-email-jolsa@kernel.org> References: <1483431600-19887-4-git-send-email-jolsa@kernel.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/urgent] perf record: Fix --switch-output documentation and comment Git-Commit-ID: 60437ac02f398e0ee0927748d4798dd5534ac90d X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 60437ac02f398e0ee0927748d4798dd5534ac90d Gitweb: http://git.kernel.org/tip/60437ac02f398e0ee0927748d4798dd5534ac90d Author: Jiri Olsa AuthorDate: Tue, 3 Jan 2017 09:19:56 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 3 Jan 2017 11:11:38 -0300 perf record: Fix --switch-output documentation and comment There's no --signal-trigger option, also adding the code comment into record man page. Signed-off-by: Jiri Olsa Tested-by: Wang Nan Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1483431600-19887-4-git-send-email-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-record.txt | 4 ++++ tools/perf/builtin-record.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 27fc361..5054d91 100644 --- a/tools/perf/Documentation/perf-record.txt +++ b/tools/perf/Documentation/perf-record.txt @@ -430,6 +430,10 @@ that gets then processed, possibly via a perf script, to decide if that particular perf.data snapshot should be kept or not. Implies --timestamp-filename, --no-buildid and --no-buildid-cache. +The reason for the latter two is to reduce the data file switching +overhead. You can still switch them on with: + + --switch-output --no-no-buildid --no-no-buildid-cache --dry-run:: Parse options then exit. --dry-run can be used to detect errors in cmdline diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 31cf0ce..4ec10e9 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -1636,7 +1636,7 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused) * overhead. Still generate buildid if they are required * explicitly using * - * perf record --signal-trigger --no-no-buildid \ + * perf record --switch-output --no-no-buildid \ * --no-no-buildid-cache * * Following code equals to: