Re: [PATCH 2/5] x86/asm/entry/64: simplify retint_kernel label usage, make retint_restore_args label local

Linus Torvalds
2015-03-30T18:18:50Z

On Mon, Mar 30, 2015 at 11:09 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>
> Strip retint_kernel of .global-ness (ENTRY macro) - it has no users
> outside of this file.

The reason for the ENTRY is to get it aligned, not because it's
globally visible. It doesn't have any fallthroughs, and some cpu's
care more than others.

See commit b06babac45e1 ("Add proper alignment to ENTRY").

Not that I'm sure the alignment matters all that much, but I thought
I'd point it out. Removing the ENTRY() does a lot more than just
remote the .globl.

Linus