Re: [PATCH 5/5] x86/asm/entry/64: drop exit_intr label

Linus Torvalds
2015-03-30T18:22:58Z

On Mon, Mar 30, 2015 at 11:09 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> - cmpl $0,PER_CPU_VAR(__preempt_count)
> - jnz 1f
> - bt $9,EFLAGS(%rsp) /* interrupts were off? */
> + bt $X86_EFLAGS_IF_BIT,EFLAGS(%rsp) /* interrupts were off? */

Since you're changing this anyway, just change it to use "testb" the
way you did the other place.

Yeah, yeah, it might make it less readable, but

testb $2,EFLAGS+1(%rsp) /* interrupts were off? */

should be smaller and faster than "bt", and the point of this commit
was to make code smaller and faster, no?

Linus