From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbcHKL7K (ORCPT ); Thu, 11 Aug 2016 07:59:10 -0400 Received: from terminus.zytor.com ([198.137.202.10]:53374 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932393AbcHKL6z (ORCPT ); Thu, 11 Aug 2016 07:58:55 -0400 Date: Thu, 11 Aug 2016 04:56:02 -0700 From: tip-bot for Nicolas Iooss Message-ID: Cc: bp@alien8.de, hpa@zytor.com, keescook@chromium.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, nicolas.iooss_linux@m4x.org, peterz@infradead.org, dvlasenk@redhat.com, mingo@kernel.org, torvalds@linux-foundation.org, brgerst@gmail.com, luto@kernel.org, jpoimboe@redhat.com Reply-To: jpoimboe@redhat.com, brgerst@gmail.com, mingo@kernel.org, torvalds@linux-foundation.org, luto@kernel.org, dvlasenk@redhat.com, nicolas.iooss_linux@m4x.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, hpa@zytor.com, keescook@chromium.org, bp@alien8.de In-Reply-To: <20160806102039.27221-1-nicolas.iooss_linux@m4x.org> References: <20160806102039.27221-1-nicolas.iooss_linux@m4x.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/urgent] x86/mm/kaslr: Fix -Wformat-security warning Git-Commit-ID: 62d16b5a3fca4d186e13215e0d7d2f6d36191796 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 62d16b5a3fca4d186e13215e0d7d2f6d36191796 Gitweb: http://git.kernel.org/tip/62d16b5a3fca4d186e13215e0d7d2f6d36191796 Author: Nicolas Iooss AuthorDate: Sat, 6 Aug 2016 12:20:39 +0200 Committer: Ingo Molnar CommitDate: Thu, 11 Aug 2016 10:58:12 +0200 x86/mm/kaslr: Fix -Wformat-security warning debug_putstr() is used to output strings without using printf-like formatting but debug_putstr(v) is defined as early_printk(v) in arch/x86/lib/kaslr.c. This makes clang reports the following warning when building with -Wformat-security: arch/x86/lib/kaslr.c:57:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] debug_putstr(purpose); ^~~~~~~ Fix this by using "%s" in early_printk(). Signed-off-by: Nicolas Iooss Acked-by: Kees Cook Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20160806102039.27221-1-nicolas.iooss_linux@m4x.org Signed-off-by: Ingo Molnar --- arch/x86/lib/kaslr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c index f7dfeda..121f59c 100644 --- a/arch/x86/lib/kaslr.c +++ b/arch/x86/lib/kaslr.c @@ -19,7 +19,7 @@ #include #include -#define debug_putstr(v) early_printk(v) +#define debug_putstr(v) early_printk("%s", v) #define has_cpuflag(f) boot_cpu_has(f) #define get_boot_seed() kaslr_offset() #endif