From: tip-bot for Adrian Hunter <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
tglx@linutronix.de, acme@redhat.com, ak@linux.intel.com,
hpa@zytor.com, mingo@kernel.org
Subject: [tip:perf/core] perf auxtrace: Add CPU filter support
Date: Sat, 1 Jul 2017 01:56:23 -0700 [thread overview]
Message-ID: <tip-644e0840ad4615e032d67adec6ee60f821b669fe@git.kernel.org> (raw)
In-Reply-To: <1495786658-18063-38-git-send-email-adrian.hunter@intel.com>
Commit-ID: 644e0840ad4615e032d67adec6ee60f821b669fe
Gitweb: http://git.kernel.org/tip/644e0840ad4615e032d67adec6ee60f821b669fe
Author: Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Fri, 26 May 2017 11:17:38 +0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 30 Jun 2017 11:50:55 -0300
perf auxtrace: Add CPU filter support
Decoding auxtrace data can take a long time. To avoid decoding
unnecessarily, filter auxtrace data that is collected per-cpu before it is
decoded.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Link: http://lkml.kernel.org/r/1495786658-18063-38-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-report.c | 1 +
tools/perf/builtin-script.c | 1 +
tools/perf/util/auxtrace.c | 10 ++++++++++
tools/perf/util/auxtrace.h | 2 ++
4 files changed, 14 insertions(+)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 1174a42..79a33eb 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -557,6 +557,7 @@ static int __cmd_report(struct report *rep)
ui__error("failed to set cpu bitmap\n");
return ret;
}
+ session->itrace_synth_opts->cpu_bitmap = rep->cpu_bitmap;
}
if (rep->show_threads) {
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index b458a0c..83cdc0a 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2992,6 +2992,7 @@ int cmd_script(int argc, const char **argv)
err = perf_session__cpu_bitmap(session, cpu_list, cpu_bitmap);
if (err < 0)
goto out_delete;
+ itrace_synth_opts.cpu_bitmap = cpu_bitmap;
}
if (!no_callchain)
diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
index 651c01d..5547457 100644
--- a/tools/perf/util/auxtrace.c
+++ b/tools/perf/util/auxtrace.c
@@ -322,6 +322,13 @@ static int auxtrace_queues__add_event_buffer(struct auxtrace_queues *queues,
return auxtrace_queues__add_buffer(queues, idx, buffer);
}
+static bool filter_cpu(struct perf_session *session, int cpu)
+{
+ unsigned long *cpu_bitmap = session->itrace_synth_opts->cpu_bitmap;
+
+ return cpu_bitmap && cpu != -1 && !test_bit(cpu, cpu_bitmap);
+}
+
int auxtrace_queues__add_event(struct auxtrace_queues *queues,
struct perf_session *session,
union perf_event *event, off_t data_offset,
@@ -331,6 +338,9 @@ int auxtrace_queues__add_event(struct auxtrace_queues *queues,
unsigned int idx;
int err;
+ if (filter_cpu(session, event->auxtrace.cpu))
+ return 0;
+
buffer = zalloc(sizeof(struct auxtrace_buffer));
if (!buffer)
return -ENOMEM;
diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
index 68e0aa4..33b5e6c 100644
--- a/tools/perf/util/auxtrace.h
+++ b/tools/perf/util/auxtrace.h
@@ -74,6 +74,7 @@ enum itrace_period_type {
* @period: 'instructions' events period
* @period_type: 'instructions' events period type
* @initial_skip: skip N events at the beginning.
+ * @cpu_bitmap: CPUs for which to synthesize events, or NULL for all
*/
struct itrace_synth_opts {
bool set;
@@ -96,6 +97,7 @@ struct itrace_synth_opts {
unsigned long long period;
enum itrace_period_type period_type;
unsigned long initial_skip;
+ unsigned long *cpu_bitmap;
};
/**
next prev parent reply other threads:[~2017-07-01 8:57 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 8:17 [PATCH V2 00/37] perf intel-pt: Power events and PTWRITE Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 01/37] perf intel-pt: Move decoder error setting into one condition Adrian Hunter
2017-06-21 18:19 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 02/37] perf intel-pt: Improve sample timestamp Adrian Hunter
2017-06-21 18:20 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 03/37] perf intel-pt: Fix missing stack clear Adrian Hunter
2017-06-21 18:20 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 04/37] perf intel-pt: Ensure IP is zero when state is INTEL_PT_STATE_NO_IP Adrian Hunter
2017-06-21 18:21 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 05/37] perf intel-pt: Fix last_ip usage Adrian Hunter
2017-06-21 18:22 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 06/37] perf intel-pt: Ensure never to set 'last_ip' when packet 'count' is zero Adrian Hunter
2017-06-21 18:22 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 07/37] perf intel-pt: Use FUP always when scanning for an IP Adrian Hunter
2017-06-21 18:23 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 08/37] perf intel-pt: Clear FUP flag on error Adrian Hunter
2017-06-21 18:23 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 09/37] perf intel-pt: Add missing __fallthrough Adrian Hunter
2017-06-21 18:24 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 10/37] perf intel-pt: Allow decoding with branch tracing disabled Adrian Hunter
2017-06-21 18:24 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 11/37] perf intel-pt: Add default config for pass-through branch enable Adrian Hunter
2017-06-21 18:25 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 12/37] perf intel-pt: Add documentation for new config terms Adrian Hunter
2017-06-21 18:25 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 13/37] perf intel-pt: Add decoder support for ptwrite and power event packets Adrian Hunter
2017-06-21 18:26 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 14/37] perf intel-pt: Add reserved byte to CBR packet payload Adrian Hunter
2017-06-21 18:27 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 15/37] perf intel-pt: Add decoder support for CBR events Adrian Hunter
2017-06-21 18:27 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 16/37] perf intel-pt: Remove redundant initial_skip checks Adrian Hunter
2017-06-21 18:28 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 17/37] perf intel-pt: Fix transactions_sample_type Adrian Hunter
2017-06-21 18:28 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 18/37] perf tools: Fix message because cpu list option is -C not -c Adrian Hunter
2017-06-21 18:29 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 19/37] perf script: Fix message because field list option is -F not -f Adrian Hunter
2017-06-21 18:29 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 20/37] perf script: Add 'synth' event type for synthesized events Adrian Hunter
2017-06-21 10:17 ` [PATCH V3 " Adrian Hunter
2017-06-21 13:51 ` Arnaldo Carvalho de Melo
2017-06-21 16:41 ` Adrian Hunter
2017-06-21 17:29 ` Arnaldo Carvalho de Melo
2017-06-21 20:20 ` Adrian Hunter
2017-06-22 14:59 ` Arnaldo Carvalho de Melo
2017-07-01 8:50 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 21/37] perf script: Add 'synth' field for synthesized event payloads Adrian Hunter
2017-06-21 10:17 ` [PATCH V3 " Adrian Hunter
2017-07-01 8:51 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 22/37] tools include: Add byte-swapping macros to kernel.h Adrian Hunter
2017-07-01 8:50 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 23/37] perf auxtrace: Add itrace option to output ptwrite events Adrian Hunter
2017-07-01 8:51 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 24/37] perf auxtrace: Add itrace option to output power events Adrian Hunter
2017-07-01 8:51 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events Adrian Hunter
2017-06-28 13:04 ` Arnaldo Carvalho de Melo
2017-06-28 17:40 ` Adrian Hunter
2017-06-28 18:53 ` Arnaldo Carvalho de Melo
2017-06-28 20:21 ` Hunter, Adrian
2017-06-28 20:26 ` Arnaldo Carvalho de Melo
2017-06-29 19:56 ` Adrian Hunter
2017-06-29 20:13 ` Arnaldo Carvalho de Melo
2017-06-30 2:08 ` Arnaldo Carvalho de Melo
2017-06-30 8:51 ` Adrian Hunter
2017-06-30 14:54 ` Arnaldo Carvalho de Melo
2017-06-30 19:37 ` Hunter, Adrian
2017-06-30 8:36 ` [PATCH V3 " Adrian Hunter
2017-07-01 8:52 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 26/37] perf intel-pt: Factor out common code synthesizing event samples Adrian Hunter
2017-07-01 8:52 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 27/37] perf intel-pt: Remove unused instructions_sample_period Adrian Hunter
2017-07-01 8:52 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 28/37] perf intel-pt: Join needlessly wrapped lines Adrian Hunter
2017-07-01 8:53 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 29/37] perf intel-pt: Tidy Intel PT evsel lookup into separate function Adrian Hunter
2017-07-01 8:53 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 30/37] perf intel-pt: Tidy messages into called function intel_pt_synth_event() Adrian Hunter
2017-07-01 8:53 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 31/37] perf intel-pt: Factor out intel_pt_set_event_name() Adrian Hunter
2017-07-01 8:54 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 32/37] perf intel-pt: Move code in intel_pt_synth_events() to simplify attr setting Adrian Hunter
2017-07-01 8:54 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 33/37] perf intel-pt: Synthesize new power and ptwrite events Adrian Hunter
2017-06-30 8:36 ` [PATCH V3 " Adrian Hunter
2017-07-01 8:54 ` [tip:perf/core] perf intel-pt: Synthesize new power and "ptwrite" events tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 34/37] perf intel-pt: Add example script for power events and PTWRITE Adrian Hunter
2017-07-01 8:55 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 35/37] perf intel-pt: Update documentation to include new ptwrite and power events Adrian Hunter
2017-07-01 8:55 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 36/37] perf intel-pt: Do not use TSC packets for calculating CPU cycles to TSC Adrian Hunter
2017-07-01 8:56 ` [tip:perf/core] " tip-bot for Adrian Hunter
2017-05-26 8:17 ` [PATCH V2 37/37] perf auxtrace: Add CPU filter support Adrian Hunter
2017-07-01 8:56 ` tip-bot for Adrian Hunter [this message]
2017-06-12 13:04 ` [PATCH V2 00/37] perf intel-pt: Power events and PTWRITE Adrian Hunter
2017-06-12 13:56 ` Arnaldo Carvalho de Melo
2017-06-21 10:20 ` Adrian Hunter
2017-06-21 13:40 ` Arnaldo Carvalho de Melo
2017-06-27 15:27 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-644e0840ad4615e032d67adec6ee60f821b669fe@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox