From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753275AbbKZIVL (ORCPT ); Thu, 26 Nov 2015 03:21:11 -0500 Received: from terminus.zytor.com ([198.137.202.10]:56056 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbbKZIVE (ORCPT ); Thu, 26 Nov 2015 03:21:04 -0500 Date: Thu, 26 Nov 2015 00:20:46 -0800 From: tip-bot for Jiri Olsa Message-ID: Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, wangnan0@huawei.com, jolsa@kernel.org, masami.hiramatsu.pt@hitachi.com, hpa@zytor.com, acme@redhat.com, namhyung@kernel.org, mingo@kernel.org Reply-To: namhyung@kernel.org, masami.hiramatsu.pt@hitachi.com, hpa@zytor.com, acme@redhat.com, mingo@kernel.org, jolsa@redhat.com, linux-kernel@vger.kernel.org, jolsa@kernel.org, tglx@linutronix.de, wangnan0@huawei.com In-Reply-To: <20151121102355.GA17313@krava.local> References: <20151121102355.GA17313@krava.local> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf callchain: Add missing parent_val initialization Git-Commit-ID: 646a6e846c4dc3812c614fd061603b6db5b8d380 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 646a6e846c4dc3812c614fd061603b6db5b8d380 Gitweb: http://git.kernel.org/tip/646a6e846c4dc3812c614fd061603b6db5b8d380 Author: Jiri Olsa AuthorDate: Sat, 21 Nov 2015 11:23:55 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 23 Nov 2015 18:31:25 -0300 perf callchain: Add missing parent_val initialization Adding missing parent_val callchain_node initialization. It's causing segfault in perf top: $ sudo perf top -g perf: Segmentation fault -------- backtrace -------- free_callchain_node(+0x29) in perf [0x4a4b3e] free_callchain(+0x29) in perf [0x4a5a83] hist_entry__delete(+0x126) in perf [0x4c6649] hists__delete_entry(+0x6e) in perf [0x4c66dc] hists__decay_entries(+0x7d) in perf [0x4c6776] perf_top__sort_new_samples(+0x7c) in perf [0x436a78] hist_browser__run(+0xf2) in perf [0x507760] perf_evsel__hists_browse(+0x1da) in perf [0x507c8d] perf_evlist__tui_browse_hists(+0x3e) in perf [0x5088cf] display_thread_tui(+0x7f) in perf [0x437953] start_thread(+0xc5) in libpthread-2.21.so [0x7f7068fbb555] __clone(+0x6d) in libc-2.21.so [0x7f7066fc3b9d] [0x0] Reported-and-Tested-by: Arnaldo Carvalho de Melo Signed-off-by: Jiri Olsa Acked-by: Namhyung Kim Cc: Masami Hiramatsu Cc: Wang Nan Fixes: 4b3a3212233a ("perf hists browser: Support flat callchains") Link: http://lkml.kernel.org/r/20151121102355.GA17313@krava.local Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/callchain.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h index 6e9b5f2..8ac8f043 100644 --- a/tools/perf/util/callchain.h +++ b/tools/perf/util/callchain.h @@ -143,6 +143,7 @@ extern __thread struct callchain_cursor callchain_cursor; static inline void callchain_init(struct callchain_root *root) { INIT_LIST_HEAD(&root->node.val); + INIT_LIST_HEAD(&root->node.parent_val); root->node.parent = NULL; root->node.hit = 0;