Re: [PATCHv3 3/3] [PATCHv3 3/3] tracing - trace parser support for set_graph_function set_ftrace_filter set_ftrace_notrace

Steven Rostedt
2009-09-11T19:20:11Z

Nit - fix your scripts again. The subject duplicates the [PATCHv3 3/3].

On Fri, 2009-09-11 at 17:29 +0200, jolsa@redhat.com wrote:

> Fixed minor in set_graph_function display - g_show function.

> @@ -2499,7 +2456,7 @@ static int g_show(struct seq_file *m, void *v)
> return 0;
> }
>
> - seq_printf(m, "%pf\n", v);
> + seq_printf(m, "%p\n", (void *) *ptr);
>
> return 0;
> }

I changed this, because it has a bug itself. You just changed the way
set_graph_function works.

It use to do:

# echo sys_open > set_graph_function
# cat set_graph_function
sys_open

After this change, it does

# echo sys_open > set_graph_function
# cat set_graph_function
ffffffff811020d0

Which is not very helpful.

But, you did catch a bug. Another clean up patch, made it from *ptr to
v, which is wrong. Half that change is correct ;-)

Thus I modified this patch with the following change:

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 7d68163..8b23d56 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2456,7 +2456,7 @@ static int g_show(struct seq_file *m, void *v)
return 0;
}

- seq_printf(m, "%p\n", (void *) *ptr);
+ seq_printf(m, "%pf\n", (void *)*ptr);

return 0;
}

-- Steve