public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Michael Neuling <mikey@neuling.org>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	a.p.zijlstra@chello.nl, tglx@linutronix.de, mingo@elte.hu,
	mikey@neuling.org
Subject: [tip:sched/core] sched: Fix fix_small_capacity
Date: Fri, 18 Jun 2010 10:18:51 GMT	[thread overview]
Message-ID: <tip-694f5a1112959a6996cabdb6f8d3003e87dac8a7@git.kernel.org> (raw)
In-Reply-To: <12629.1276124617@neuling.org>

Commit-ID:  694f5a1112959a6996cabdb6f8d3003e87dac8a7
Gitweb:     http://git.kernel.org/tip/694f5a1112959a6996cabdb6f8d3003e87dac8a7
Author:     Michael Neuling <mikey@neuling.org>
AuthorDate: Thu, 10 Jun 2010 09:03:37 +1000
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 18 Jun 2010 10:46:54 +0200

sched: Fix fix_small_capacity

The CPU power test is the wrong way around in fix_small_capacity.

This was due to a small changes made in the posted patch on lkml to what
was was taken upstream.

This patch fixes asymmetric packing for POWER7.

Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <12629.1276124617@neuling.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched_fair.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 593424f..e82c572 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -2354,7 +2354,7 @@ fix_small_capacity(struct sched_domain *sd, struct sched_group *group)
 	/*
 	 * If ~90% of the cpu_power is still there, we're good.
 	 */
-	if (group->cpu_power * 32 < group->cpu_power_orig * 29)
+	if (group->cpu_power * 32 > group->cpu_power_orig * 29)
 		return 1;
 
 	return 0;

  parent reply	other threads:[~2010-06-18 10:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08  4:57 [PATCH 0/3] sched: asymmetrical packing for POWER7 SMT4 Michael Neuling
2010-06-08  4:57 ` [PATCH 1/3] sched: fix capacity calculations for SMT4 Michael Neuling
2010-06-09 10:14   ` [tip:sched/core] sched: Fix " tip-bot for Srivatsa Vaddagiri
2010-06-09 23:03     ` Michael Neuling
2010-06-10  2:06       ` [PATCH] sched: update comments to make docbook happy Michael Neuling
2010-06-18 10:19         ` [tip:sched/core] sched: Fix comments to make them DocBook happy tip-bot for Michael Neuling
2010-06-10  6:48       ` [tip:sched/core] sched: Fix capacity calculations for SMT4 Peter Zijlstra
2010-06-17 23:04         ` Michael Neuling
2010-06-18 10:18       ` tip-bot for Michael Neuling [this message]
2010-06-08  4:57 ` [PATCH 3/3] powerpc: enabled asymmetric SMT scheduling on POWER7 Michael Neuling
2010-06-09  8:54   ` Benjamin Herrenschmidt
2010-06-09 10:18   ` [tip:sched/core] powerpc: Enable " tip-bot for Michael Neuling
2010-06-09 14:27     ` [tip:sched/core] powerpc: Exclude arch_sd_sibiling_asym_packing() on UP tip-bot for Peter Zijlstra
2010-06-09 14:33     ` tip-bot for Peter Zijlstra
2010-06-08  4:57 ` [PATCH 2/3] sched: add asymmetric group packing option for sibling domain Michael Neuling
2010-06-09 10:14   ` [tip:sched/core] sched: Add " tip-bot for Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-694f5a1112959a6996cabdb6f8d3003e87dac8a7@git.kernel.org \
    --to=mikey@neuling.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox