From: tip-bot for Peter Zijlstra <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
mingo@kernel.org, peterz@infradead.org, tglx@linutronix.de,
mtk.manpages@gmail.com
Subject: [tip:sched/urgent] sched: Add 'flags' argument to sched_{set, get}attr() syscalls
Date: Fri, 21 Feb 2014 12:32:38 -0800 [thread overview]
Message-ID: <tip-6d35ab48090b10c5ea5604ed5d6e91f302dc6060@git.kernel.org> (raw)
In-Reply-To: <20140214161929.GL27965@twins.programming.kicks-ass.net>
Commit-ID: 6d35ab48090b10c5ea5604ed5d6e91f302dc6060
Gitweb: http://git.kernel.org/tip/6d35ab48090b10c5ea5604ed5d6e91f302dc6060
Author: Peter Zijlstra <peterz@infradead.org>
AuthorDate: Fri, 14 Feb 2014 17:19:29 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 21 Feb 2014 21:27:10 +0100
sched: Add 'flags' argument to sched_{set,get}attr() syscalls
Because of a recent syscall design debate; its deemed appropriate for
each syscall to have a flags argument for future extension; without
immediately requiring new syscalls.
Cc: juri.lelli@gmail.com
Cc: Ingo Molnar <mingo@redhat.com>
Suggested-by: Michael Kerrisk <mtk.manpages@gmail.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20140214161929.GL27965@twins.programming.kicks-ass.net
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
include/linux/syscalls.h | 6 ++++--
kernel/sched/core.c | 11 ++++++-----
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 40ed9e9..a747a77 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -281,13 +281,15 @@ asmlinkage long sys_sched_setscheduler(pid_t pid, int policy,
asmlinkage long sys_sched_setparam(pid_t pid,
struct sched_param __user *param);
asmlinkage long sys_sched_setattr(pid_t pid,
- struct sched_attr __user *attr);
+ struct sched_attr __user *attr,
+ unsigned int flags);
asmlinkage long sys_sched_getscheduler(pid_t pid);
asmlinkage long sys_sched_getparam(pid_t pid,
struct sched_param __user *param);
asmlinkage long sys_sched_getattr(pid_t pid,
struct sched_attr __user *attr,
- unsigned int size);
+ unsigned int size,
+ unsigned int flags);
asmlinkage long sys_sched_setaffinity(pid_t pid, unsigned int len,
unsigned long __user *user_mask_ptr);
asmlinkage long sys_sched_getaffinity(pid_t pid, unsigned int len,
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index a6e7470..6edbef2 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3661,13 +3661,14 @@ SYSCALL_DEFINE2(sched_setparam, pid_t, pid, struct sched_param __user *, param)
* @pid: the pid in question.
* @uattr: structure containing the extended parameters.
*/
-SYSCALL_DEFINE2(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr)
+SYSCALL_DEFINE3(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr,
+ unsigned int, flags)
{
struct sched_attr attr;
struct task_struct *p;
int retval;
- if (!uattr || pid < 0)
+ if (!uattr || pid < 0 || flags)
return -EINVAL;
if (sched_copy_attr(uattr, &attr))
@@ -3804,8 +3805,8 @@ err_size:
* @uattr: structure containing the extended parameters.
* @size: sizeof(attr) for fwd/bwd comp.
*/
-SYSCALL_DEFINE3(sched_getattr, pid_t, pid, struct sched_attr __user *, uattr,
- unsigned int, size)
+SYSCALL_DEFINE4(sched_getattr, pid_t, pid, struct sched_attr __user *, uattr,
+ unsigned int, size, unsigned int, flags)
{
struct sched_attr attr = {
.size = sizeof(struct sched_attr),
@@ -3814,7 +3815,7 @@ SYSCALL_DEFINE3(sched_getattr, pid_t, pid, struct sched_attr __user *, uattr,
int retval;
if (!uattr || pid < 0 || size > PAGE_SIZE ||
- size < SCHED_ATTR_SIZE_VER0)
+ size < SCHED_ATTR_SIZE_VER0 || flags)
return -EINVAL;
rcu_read_lock();
next prev parent reply other threads:[~2014-02-21 20:33 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 12:27 [PATCH 00/13] sched, deadline: patches Peter Zijlstra
2013-12-17 12:27 ` [PATCH 01/13] sched: Add 3 new scheduler syscalls to support an extended scheduling parameters ABI Peter Zijlstra
2014-01-21 14:36 ` Michael Kerrisk
2014-01-21 15:38 ` Peter Zijlstra
2014-01-21 15:46 ` Peter Zijlstra
2014-01-21 16:02 ` Steven Rostedt
2014-01-21 16:06 ` Peter Zijlstra
2014-01-21 16:46 ` Juri Lelli
2014-02-14 14:13 ` Michael Kerrisk (man-pages)
2014-02-14 16:19 ` Peter Zijlstra
2014-02-15 12:52 ` Ingo Molnar
2014-02-17 13:20 ` Michael Kerrisk (man-pages)
2014-04-09 9:25 ` sched_{set,get}attr() manpage Peter Zijlstra
2014-04-09 15:19 ` Henrik Austad
2014-04-09 15:42 ` Peter Zijlstra
2014-04-10 7:47 ` Juri Lelli
2014-04-10 9:59 ` Claudio Scordino
2014-04-27 15:47 ` Michael Kerrisk (man-pages)
2014-04-27 19:34 ` Peter Zijlstra
2014-04-27 19:45 ` Steven Rostedt
2014-04-28 7:39 ` Juri Lelli
2014-04-28 8:18 ` Peter Zijlstra
2014-04-29 13:08 ` Michael Kerrisk (man-pages)
2014-04-29 14:22 ` Peter Zijlstra
2014-04-29 16:04 ` Peter Zijlstra
2014-04-30 11:09 ` Michael Kerrisk (man-pages)
2014-04-30 12:35 ` Peter Zijlstra
2014-04-30 13:09 ` Peter Zijlstra
2014-05-03 10:43 ` Juri Lelli
2014-05-05 6:55 ` Michael Kerrisk (man-pages)
2014-05-05 7:21 ` Peter Zijlstra
2014-05-05 7:41 ` Michael Kerrisk (man-pages)
2014-05-05 7:47 ` Peter Zijlstra
2014-05-05 9:53 ` Michael Kerrisk (man-pages)
2014-05-06 8:16 ` Peter Zijlstra
2014-05-09 8:23 ` Michael Kerrisk (man-pages)
2014-05-09 8:53 ` Peter Zijlstra
2014-05-09 9:26 ` Michael Kerrisk (man-pages)
2014-05-19 13:06 ` [tip:sched/core] sched: Disallow sched_attr::sched_policy < 0 tip-bot for Peter Zijlstra
2014-05-22 12:25 ` tip-bot for Peter Zijlstra
2014-02-21 20:32 ` tip-bot for Peter Zijlstra [this message]
2014-01-26 9:48 ` [PATCH 01/13] sched: Add 3 new scheduler syscalls to support an extended scheduling parameters ABI Geert Uytterhoeven
2013-12-17 12:27 ` [PATCH 02/13] sched: SCHED_DEADLINE structures & implementation Peter Zijlstra
2013-12-17 12:27 ` [PATCH 03/13] sched: SCHED_DEADLINE SMP-related data structures & logic Peter Zijlstra
2013-12-17 12:27 ` [PATCH 04/13] [PATCH 05/13] sched: SCHED_DEADLINE avg_update accounting Peter Zijlstra
2013-12-17 12:27 ` [PATCH 05/13] sched: Add period support for -deadline tasks Peter Zijlstra
2013-12-17 12:27 ` [PATCH 06/13] [PATCH 07/13] sched: Add latency tracing " Peter Zijlstra
2013-12-17 12:27 ` [PATCH 07/13] rtmutex: Turn the plist into an rb-tree Peter Zijlstra
2013-12-17 12:27 ` [PATCH 08/13] sched: Drafted deadline inheritance logic Peter Zijlstra
2013-12-17 12:27 ` [PATCH 09/13] sched: Add bandwidth management for sched_dl Peter Zijlstra
2013-12-18 16:55 ` Peter Zijlstra
2013-12-20 17:13 ` Peter Zijlstra
2013-12-20 17:37 ` Steven Rostedt
2013-12-20 17:42 ` Peter Zijlstra
2013-12-20 18:23 ` Steven Rostedt
2013-12-20 18:26 ` Steven Rostedt
2013-12-20 21:44 ` Peter Zijlstra
2013-12-20 23:29 ` Steven Rostedt
2013-12-21 10:05 ` Peter Zijlstra
2013-12-21 17:26 ` Peter Zijlstra
2014-01-13 15:55 ` [tip:sched/core] sched/deadline: Fix hotplug admission control tip-bot for Peter Zijlstra
2013-12-17 12:27 ` [PATCH 10/13] sched: speed up -dl pushes with a push-heap Peter Zijlstra
2013-12-17 12:27 ` [PATCH 11/13] sched: Remove sched_setscheduler2() Peter Zijlstra
2013-12-17 12:27 ` [PATCH 12/13] sched, deadline: Fixup the smp-affinity mask tests Peter Zijlstra
2013-12-17 12:27 ` [PATCH 13/13] sched, deadline: Remove the sysctl_sched_dl knobs Peter Zijlstra
2013-12-17 20:17 ` [PATCH] sched, deadline: Properly initialize def_dl_bandwidth lock Steven Rostedt
2013-12-18 10:01 ` Peter Zijlstra
2013-12-20 13:51 ` [PATCH 00/13] sched, deadline: patches Juri Lelli
2013-12-20 14:28 ` Steven Rostedt
2013-12-20 14:51 ` Peter Zijlstra
2013-12-20 15:19 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-6d35ab48090b10c5ea5604ed5d6e91f302dc6060@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).