public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Tommy Nguyen <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: remyabel@gmail.com, mingo@kernel.org, peterz@infradead.org,
	hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org
Subject: [tip:x86/cleanups] x86/boot: Add missing strchr() declaration
Date: Sat, 24 Jun 2017 00:18:57 -0700	[thread overview]
Message-ID: <tip-6ec829a9d1c8562ac15c50402e5de550bb28161e@git.kernel.org> (raw)
In-Reply-To: <20170623143601.GA20743@NoChina>

Commit-ID:  6ec829a9d1c8562ac15c50402e5de550bb28161e
Gitweb:     http://git.kernel.org/tip/6ec829a9d1c8562ac15c50402e5de550bb28161e
Author:     Tommy Nguyen <remyabel@gmail.com>
AuthorDate: Fri, 23 Jun 2017 10:36:01 -0400
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 24 Jun 2017 08:53:33 +0200

x86/boot: Add missing strchr() declaration

The Sparse static analyzer emits this warning:

    symbol 'strchr' was not declared. Should it be static?

This patch adds the appropriate extern declaration to string.h
to fix the warning.

Signed-off-by: Tommy Nguyen <remyabel@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170623143601.GA20743@NoChina
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/boot/string.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index 113588d..f274a50 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -22,6 +22,7 @@ extern int strcmp(const char *str1, const char *str2);
 extern int strncmp(const char *cs, const char *ct, size_t count);
 extern size_t strlen(const char *s);
 extern char *strstr(const char *s1, const char *s2);
+extern char *strchr(const char *s, int c);
 extern size_t strnlen(const char *s, size_t maxlen);
 extern unsigned int atou(const char *s);
 extern unsigned long long simple_strtoull(const char *cp, char **endp,

      reply	other threads:[~2017-06-24  7:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-23 14:36 [PATCH] x86/boot/string: Add missing strchr declaration Tommy Nguyen
2017-06-24  7:18 ` tip-bot for Tommy Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-6ec829a9d1c8562ac15c50402e5de550bb28161e@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=remyabel@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox