public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Masami Hiramatsu <mhiramat@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	jkenisto@us.ibm.com, rdunlap@xenotime.net, tglx@linutronix.de,
	sfr@canb.auug.org.au, mhiramat@redhat.com, mingo@elte.hu
Subject: [tip:perf/probes] x86: insn decoder test checks objdump version
Date: Sat, 21 Nov 2009 07:10:06 GMT	[thread overview]
Message-ID: <tip-6f5f67267dc4faecd9cba63894de92ca92a608b8@git.kernel.org> (raw)
In-Reply-To: <20091120171314.6715.30390.stgit@dhcp-100-2-132.bos.redhat.com>

Commit-ID:  6f5f67267dc4faecd9cba63894de92ca92a608b8
Gitweb:     http://git.kernel.org/tip/6f5f67267dc4faecd9cba63894de92ca92a608b8
Author:     Masami Hiramatsu <mhiramat@redhat.com>
AuthorDate: Fri, 20 Nov 2009 12:13:14 -0500
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Fri, 20 Nov 2009 23:01:04 -0800

x86: insn decoder test checks objdump version

Check objdump version before using it for insn decoder build test,
because some older objdump can't decode AVX code correctly.

Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Jim Keniston <jkenisto@us.ibm.com>
LKML-Reference: <20091120171314.6715.30390.stgit@dhcp-100-2-132.bos.redhat.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/tools/Makefile       |    5 ++++-
 arch/x86/tools/chkobjdump.awk |   23 +++++++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletions(-)

diff --git a/arch/x86/tools/Makefile b/arch/x86/tools/Makefile
index c80b079..f820826 100644
--- a/arch/x86/tools/Makefile
+++ b/arch/x86/tools/Makefile
@@ -12,8 +12,11 @@ else
   posttest_64bit = -n
 endif
 
+distill_awk = $(srctree)/arch/x86/tools/distill.awk
+chkobjdump = $(srctree)/arch/x86/tools/chkobjdump.awk
+
 quiet_cmd_posttest = TEST    $@
-      cmd_posttest = $(OBJDUMP) -d -j .text $(objtree)/vmlinux | $(AWK) -f $(srctree)/arch/x86/tools/distill.awk | $(obj)/test_get_len $(posttest_64bit) $(posttest_verbose)
+      cmd_posttest = ($(OBJDUMP) -v | $(AWK) -f $(chkobjdump)) || $(OBJDUMP) -d -j .text $(objtree)/vmlinux | $(AWK) -f $(distill_awk) | $(obj)/test_get_len $(posttest_64bit) $(posttest_verbose)
 
 posttest: $(obj)/test_get_len vmlinux
 	$(call cmd,posttest)
diff --git a/arch/x86/tools/chkobjdump.awk b/arch/x86/tools/chkobjdump.awk
new file mode 100644
index 0000000..0d13cd9
--- /dev/null
+++ b/arch/x86/tools/chkobjdump.awk
@@ -0,0 +1,23 @@
+# GNU objdump version checker
+#
+# Usage:
+# objdump -v | awk -f chkobjdump.awk
+BEGIN {
+	# objdump version 2.19 or later is OK for the test.
+	od_ver = 2;
+	od_sver = 19;
+}
+
+/^GNU/ {
+	split($4, ver, ".");
+	if (ver[1] > od_ver ||
+	    (ver[1] == od_ver && ver[2] >= od_sver)) {
+		exit 1;
+	} else {
+		printf("Warning: objdump version %s is older than %d.%d\n",
+		       $4, od_ver, od_sver);
+		print("Warning: Skipping posttest.");
+		# Logic is inverted, because we just skip test without error.
+		exit 0;
+	}
+}

      reply	other threads:[~2009-11-21  7:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16 23:06 [PATCH -next 0/3] x86 insn decoder test updates (Re: linux-next: Tree for October 29 (x86 posttest)) Masami Hiramatsu
2009-11-16 23:06 ` [PATCH -next 1/3] x86: Add verbose option to insn decoder test Masami Hiramatsu
2009-11-17  6:31   ` [tip:perf/probes] " tip-bot for Masami Hiramatsu
2009-11-16 23:06 ` [PATCH -next 2/3] x86: Show symbol name if insn decoder test failed Masami Hiramatsu
2009-11-17  6:31   ` [tip:perf/probes] " tip-bot for Masami Hiramatsu
2009-11-16 23:06 ` [PATCH -next 3/3] x86: insn decoder test shows build warning Masami Hiramatsu
2009-11-20  5:39   ` [tip:perf/core] x86: Instruction decoder test should generate " tip-bot for Masami Hiramatsu
2009-11-17  6:13 ` [PATCH -next 0/3] x86 insn decoder test updates (Re: linux-next: Tree for October 29 (x86 posttest)) Ingo Molnar
2009-11-17  6:55   ` Masami Hiramatsu
2009-11-18  4:42   ` H. Peter Anvin
2009-11-20 17:13   ` [PATCH -tip 0/2] x86 insn decoder test checking objdump version Masami Hiramatsu
2009-11-20 17:13     ` [PATCH -tip 1/2] [BUGFIX] x86: Fix insn decoder test typos Masami Hiramatsu
2009-11-21  7:09       ` [tip:perf/probes] " tip-bot for Masami Hiramatsu
2009-11-20 17:13     ` [PATCH -tip 2/2] x86: insn decoder test checks objdump version Masami Hiramatsu
2009-11-21  7:10       ` tip-bot for Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-6f5f67267dc4faecd9cba63894de92ca92a608b8@git.kernel.org \
    --to=mhiramat@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox