From: tip-bot for Andreas Herrmann <herrmann.der.user@googlemail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
andreas.herrmann3@amd.com, herrmann.der.user@googlemail.com,
tglx@linutronix.de, mingo@elte.hu
Subject: [tip:x86/apic] x86, apic: Clear APIC Timer Initial Count Register on shutdown
Date: Tue, 27 Oct 2009 14:00:34 GMT [thread overview]
Message-ID: <tip-6f9b41006af1bc489030f84ee247abc0df1edccd@git.kernel.org> (raw)
In-Reply-To: <20091027100138.GB30802@alberich.amd.com>
Commit-ID: 6f9b41006af1bc489030f84ee247abc0df1edccd
Gitweb: http://git.kernel.org/tip/6f9b41006af1bc489030f84ee247abc0df1edccd
Author: Andreas Herrmann <herrmann.der.user@googlemail.com>
AuthorDate: Tue, 27 Oct 2009 11:01:38 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 27 Oct 2009 14:54:21 +0100
x86, apic: Clear APIC Timer Initial Count Register on shutdown
Commit a98f8fd24fb24fcb9a359553e64dd6aac5cf4279 (x86: apic reset
counter on shutdown) set the counter to max to avoid spurious
interrupts when the timer is re-enabled.
(In theory) you'll still get a spurious interrupt if spending
more than 344 seconds with this interrupt disabled and then
unmasking it.
The right thing to do is to clear the register. This disables
the interrupt from happening (at least it does on AMD hardware).
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
LKML-Reference: <20091027100138.GB30802@alberich.amd.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/apic/apic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index dce93d4..4c689f4 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -444,7 +444,7 @@ static void lapic_timer_setup(enum clock_event_mode mode,
v = apic_read(APIC_LVTT);
v |= (APIC_LVT_MASKED | LOCAL_TIMER_VECTOR);
apic_write(APIC_LVTT, v);
- apic_write(APIC_TMICT, 0xffffffff);
+ apic_write(APIC_TMICT, 0);
break;
case CLOCK_EVT_MODE_RESUME:
/* Nothing to do here */
prev parent reply other threads:[~2009-10-27 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 10:01 [PATCH] x86, apic: Clear APIC Timer Initial Count Register on shutdown Andreas Herrmann
2009-10-27 14:00 ` tip-bot for Andreas Herrmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-6f9b41006af1bc489030f84ee247abc0df1edccd@git.kernel.org \
--to=herrmann.der.user@googlemail.com \
--cc=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox